The pmxACMEAccountView & pmxACMEPluginView in proxmox-widget-toolkit
were copied from pve-manager in commits 5df894de and 658bfdff. This
makes pveACMEAccountView & pveACMEPluginView redundant, hence remove
them and use pmxACMEAccountView & pmxACMEPluginView instead.
This leaves PVE.node.ACMEAccountView & pveACMEPluginEditor unused, so
remove them too.
Signed-off-by: Filip Schauer <f.schauer@proxmox.com>
When none of the meta fields is set by the directory, the whole
dictionary is missing from the response, leading to an exception
when testing for fields inside it.
Reported-by: Stoiko Ivanov <s.ivanov@proxmox.com>
Signed-off-by: Folke Gleumes <f.gleumes@proxmox.com>
Tested-by: Stoiko Ivanov <s.ivanov@proxmox.com>
Adds fields for eab credentials. By default eab is optional, but if the
directory should report that eab is required, the eab credential fields
are marked as mandatory and prevent the form from being submittable
until credentials are provided.
Signed-off-by: Folke Gleumes <f.gleumes@proxmox.com>
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
This patch allows the user to set a custom ACME directory by providing
a 'Custom' option in the directory dropdown. This in turn reveals an
input for the url. When using a custom directory the directory has to
be manually queried via button press to prevent from spamming the
directory on every input.
Signed-off-by: Folke Gleumes <f.gleumes@proxmox.com>
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
Besides the switch from tos to meta endpoint, this fixes a visual bug,
where the 'Accept TOS' button would show up, even if no ToS was needed.
Signed-off-by: Folke Gleumes <f.gleumes@proxmox.com>
Reviewed-by: Fabian.Grünbichler <f.gruenbichler@proxmox.com>
Tested-by: Fabian.Grünbichler <f.gruenbichler@proxmox.com>
While it makes sense to reload the Web UI after ordering a certificate
for the same node, it is unnecessary to reload the Web UI when ordering
a certificate for a different node.
Signed-off-by: Filip Schauer <f.schauer@proxmox.com>
Ext.util.Sorter does not have an 'order' property, so 'order: DESC'
didn't have an effect. The default is 'ASC' and it is arguably the
preferred direction for all affected sorters anyways.
Signed-off-by: Fabian Ebner <f.ebner@proxmox.com>
multiple users were confused[0], as they did not interpret the 'icon only'
in the toolbar as a button (and it did not help that we prevented
the cursor to change)
to improve it, make the button a normal one again, and add some
text for context (this is more inline what we do elsewhere in toolbars)
0: https://forum.proxmox.com/threads/acme-over-dnschallenge-failing.71902
Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
As else some people could be confused and put in their name, as below
is the email field, and name+email are quite often pairs.
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
by increasing the space for the link, and using a boxLabel instead
of fieldLabel, which has better spacing for longer text
also move the e-mail before the directory to have all textboxes together
Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
if the 'default' account exists, make the name field required and
remove the emptytext
get the information by querying the grid store. this may be not
up-to-date, but it is less intrusive that an extra api call that
blocks the window
Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
to order a ceritificate, we need at least one configured domain, and
the configured account (or default) must exist
so track the domaincount in the viewmodel and introduce a
'canOrder' formula which is only true when domaincount > 0 and
account is set (if the configured account does not exist, or no account
exists at all we set 'account' to 'null')
Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
instead of using API2Request manually, just reload the store of
the accountselector and check if the configured account is in it
this should fix the spurious loading mask of the panel when
loading the accounts
Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
It's not 100% true, but for the user more understandable. IF we
actually change such that this detail matters we can still go for a
"Better" solution then, as it will need UI updates anyway..
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
We have 4 call sites of that, one had a fallback - the other three
was totally unchecked and triggered already exceptions on panel
render ... -.-
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
This is basically a complete rework of the ACME grid.
Instead of having an ObjectGrid, we now have a normal
GridPanel which allows us to show a row for each Domain.
But to achieve this, we need to manually fill the store with data
from the 'acme' and 'acmedomainX' entries of the node config.
We also add an AccountSelector to the tbar and a link to the
datacenter->acme panel (when there is no account)
this also removes the 'register account' and 'view account' buttons,
since those are now available in datacenter->acme
Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
which expects a nodeconfig (for digest and domaincount)
and for the edit case, the parsed 'domain' object
this editwindow has three fields:
* type selector (standalone/dns)
* domain
* plugin (only for dns)
if the user chooses dns but there are already the maximum count of
acmedomainX entries, the type field gets invalid (with a error tooltip)
the onGetValues method is non-trivial, because of the mixing of
acmedomainX and acme.domain values, so we have to be careful
that we delete/edit the correct entry
Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
so that we can create multiple accounts, but leave it empty and set the
emptyText to the default name 'default'
Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
You can normally do this with the Order Cert button, with almost the
same result, and it isn't something which will be needed often, if
the UI is somehow inaccessible (due to cert problem) then this is
useless anyway, and the CLI must be used anyhow.
Can be easily reverted if we deem this necessary later on.
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
this provides the grid for editing domains for letsencrypt,
order/renew the certificates, and the window for creating an
ACME account
Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
