Commit Graph

282 Commits

Author SHA1 Message Date
Thomas Lamprecht
e6f39a2f8f ui: node options: simplify renderer
And drop the paranoid htmlEndoce for a integer that only users with
powerful admin privs can control anyway...

Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2025-04-05 18:16:32 +02:00
Friedrich Weber
780e053d9a ui: node options: allow editing the ballooning RAM usage target
This corresponds to the `ballooning-target` node config option.

Also make the left column slightly wider, so the texts fit better.

Signed-off-by: Friedrich Weber <f.weber@proxmox.com>
Tested-by: Stoiko Ivanov <s.ivanov@proxmox.com>
Reviewed-by: Stoiko Ivanov <s.ivanov@proxmox.com>
Link: https://lore.kernel.org/r/20250312151506.128311-4-f.weber@proxmox.com
2025-04-05 18:04:35 +02:00
Stefan Hanreich
c7f36f8890 firewall: add forward direction to rule panel
Enables us to use the new forward direction as an option when creating
or editing firewall rules. By introducing firewall_type we can switch
between the available directions depending on which ruleset is being
edited.

Signed-off-by: Stefan Hanreich <s.hanreich@proxmox.com>
Tested-by: Hannes Dürr <h.duerr@proxmox.com>
2024-11-19 16:02:16 +01:00
Aaron Lauterer
e53d33763d fix #3893: ui: network: enable bridge_vids field
Signed-off-by: Aaron Lauterer <a.lauterer@proxmox.com>
 [ TL: switch to adapted config from wtk follow-up patches ]
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2024-11-16 16:39:09 +01:00
Filip Schauer
d8f672e573 ui: acme: switch cluster view items over to those from widget-toolkit
The pmxACMEAccountView & pmxACMEPluginView in proxmox-widget-toolkit
were copied from pve-manager in commits 5df894de and 658bfdff. This
makes pveACMEAccountView & pveACMEPluginView redundant, hence remove
them and use pmxACMEAccountView & pmxACMEPluginView instead.

This leaves PVE.node.ACMEAccountView & pveACMEPluginEditor unused, so
remove them too.

Signed-off-by: Filip Schauer <f.schauer@proxmox.com>
2024-11-13 15:28:40 +01:00
Maximiliano Sandoval
cffffc36a6 fix typos in user visible strings
Found with the `typos` cli tool.

Signed-off-by: Maximiliano Sandoval <m.sandoval@proxmox.com>
2024-10-16 18:41:42 +02:00
Folke Gleumes
b3779821c2 acme: ui: handle missing meta field in directory response
When none of the meta fields is set by the directory, the whole
dictionary is missing from the response, leading to an exception
when testing for fields inside it.

Reported-by: Stoiko Ivanov <s.ivanov@proxmox.com>
Signed-off-by: Folke Gleumes <f.gleumes@proxmox.com>
Tested-by: Stoiko Ivanov <s.ivanov@proxmox.com>
2024-04-22 12:03:09 +02:00
Folke Gleumes
c18a2db238 ui: acme: add External Account Binding (EAB) related fields
Adds fields for eab credentials. By default eab is optional, but if the
directory should report that eab is required, the eab credential fields
are marked as mandatory and prevent the form from being submittable
until credentials are provided.

Signed-off-by: Folke Gleumes <f.gleumes@proxmox.com>
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2024-04-17 21:16:02 +02:00
Folke Gleumes
fdc4c229ad fix #5093: ui: acme: expose custom directory option
This patch allows the user to set a custom ACME directory by providing
a 'Custom' option in the directory dropdown. This in turn reveals an
input for the url. When using a custom directory the directory has to
be manually queried via button press to prevent from spamming the
directory on every input.

Signed-off-by: Folke Gleumes <f.gleumes@proxmox.com>
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2024-04-17 21:16:02 +02:00
Fiona Ebner
7304254a76 ui: node: system: avoid using 'Syslog'
Reported in the community forum [0]. Since Proxmox VE 8/Debian 12,
rsyslog is not installed by default for new installations anymore [1].
The information gathered by the API call comes from the systemd
journal. While 'Syslog' could be interpreted as a shorthand for
"System Log", it's better to be explicit to avoid any confusion.

In addition, the systemd journal does much more than plain syslog
messages, as argued by Fabian [2].

[0]: https://forum.proxmox.com/threads/141631/post-634675
[1]: https://www.debian.org/releases/bookworm/amd64/release-notes/ch-information.en.html#changes-to-system-logging
[2]: https://lists.proxmox.com/pipermail/pve-devel/2024-February/061765.html

Signed-off-by: Fiona Ebner <f.ebner@proxmox.com>
 [TL: Mention and link to Fabian's argument ]
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2024-02-19 14:42:59 +01:00
Fiona Ebner
4fb7e9e434 fix #5121: ui: node status: avoid invalid array access for certain foreign kernels
with custom build date format, which would prevent the panel from loading.

Signed-off-by: Fiona Ebner <f.ebner@proxmox.com>
2023-12-14 13:53:32 +01:00
Thomas Lamprecht
4a88465546 ui: drop various translations of fixed strings
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2023-11-23 09:23:23 +01:00
Thomas Lamprecht
1f1d8bf388 ui: node summary: add boot-mode information
Add a extra row for showing the current boot mode, for that we need to
grow the height of the status panel and graphs to have enough space
again.

Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2023-11-22 13:55:12 +01:00
Thomas Lamprecht
be04f8ee8a ui: node summary: reduce noise in current kernel version
use the new 'current-kernel' object returned by the node status API to
render a more useable (less noise) version information.

Keep fallback for old one to better work with upgrades (major and
minor) to this version in a cluster, where the web UI one uses might
be the new one, but a node one looks at still have the old manager.

Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2023-11-22 13:45:42 +01:00
Thomas Lamprecht
fd6fb85870 ui: node summary: drop PVE prefix for manager version
the value on the right already includes pve-manager and the user has
already loaded the PVE gui, so this is a bit superfluous

Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2023-11-22 13:45:42 +01:00
Christian Ebner
038e94bbbe fix #4442: Add date-time filtering for firewall logs
Extend the current firewall log view to add date time based filtering.
The user can switch between live view, which shows logs from the
unrotated log file, or to filter mode, where date time based filtering,
including rotated logs can be performed.

Enable the feature by setting the property and the submit format
for since and until timestamps expected by the api.

Signed-off-by: Christian Ebner <c.ebner@proxmox.com>
2023-11-13 15:23:49 +01:00
Hannes Laimer
9ed1408b09 ui: add bulk suspend support
Signed-off-by: Hannes Laimer <h.laimer@proxmox.com>
2023-11-13 14:14:08 +01:00
Folke Gleumes
7fb70c3b59 ui/acme: switch to new meta endpoint
Besides the switch from tos to meta endpoint, this fixes a visual bug,
where the 'Accept TOS' button would show up, even if no ToS was needed.

Signed-off-by: Folke Gleumes <f.gleumes@proxmox.com>
Reviewed-by: Fabian.Grünbichler <f.gruenbichler@proxmox.com>
Tested-by: Fabian.Grünbichler <f.gruenbichler@proxmox.com>
2023-11-13 12:06:10 +01:00
Dominik Csapak
ed38c56b2b ui: hide bulk migrate options on standalone nodes
since there is nowhere to migrate to and we hide the regular migrate
buttons/options too.

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
2023-11-13 11:19:46 +01:00
Thomas Lamprecht
8e642410c7 ui: subscription upload: trim key from whitespace on submission
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2023-10-05 13:43:30 +02:00
Thomas Lamprecht
a341730bd4 ui: subscription upload: increase window and label width
Quite a few translations produce a longer label here, so account for
that, the window is still very small.

Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2023-10-05 13:43:30 +02:00
Thomas Lamprecht
67dc81829f ui: subscription panel: code reduction and modernization
Drop quite a few lines while actually improving readability.

Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2023-10-05 13:43:30 +02:00
Filip Schauer
72cfb3d4a1 fix #4663: Prevent Web UI reload on cert order for other node
While it makes sense to reload the Web UI after ordering a certificate
for the same node, it is unnecessary to reload the Web UI when ordering
a certificate for a different node.

Signed-off-by: Filip Schauer <f.schauer@proxmox.com>
2023-08-22 15:50:22 +02:00
Daniel Koć
0d1108b26c ui: enable gettext localisation for more user exposed strings
Link: https://lists.proxmox.com/pipermail/pve-devel/2023-April/056588.html
Signed-off-by: Daniel Koć<daniel@xn--ko-wla.pl>
 [ T: rework subject & add S-o-b supplied by reply ]
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2023-04-24 11:52:23 +02:00
Max Carrara
9536d5ef92 ui: cert upload: fix private key field sending empty string
The private key's field is now excluded from the upload form's
JSON data if it's left empty.

Prior to this change, the form still used an empty string for the
private key's field, even if no key was provided by the user.
Because the key's field is marked as optional in the upload cert
API endpoint, JSONSchema validation would therefore fail.

Suggested-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
Signed-off-by: Max Carrara <m.carrara@proxmox.com>
2023-03-17 11:20:43 +01:00
Max Carrara
1904262b95 ui: cert upload: use inputpanel for certificate upload
This change replaces the the certificate upload form's items with
a single inputpanel widget. The components for the key and cert fields
are preserved as-is. Hardcoded values are now explicitly set in
`onGetValues` instead of using hidden widgets.

Suggested-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
Signed-off-by: Max Carrara <m.carrara@proxmox.com>
2023-03-17 11:20:43 +01:00
Fiona Ebner
0d06378c66 ui: bulk start/stop: align capability checks with backend
The backend requires VM.PowerMgmt, not Sys.PowerMgmt for bulk start
and bulk stop.

Signed-off-by: Fiona Ebner <f.ebner@proxmox.com>
2023-03-15 18:21:50 +01:00
Stefan Sterz
056e5aad9b subscription/summary/backup: stop setting the background color
setting the background color in js code adds that property as a style
attribute to the element. that makes it hard to alter later via css
and makes it hard to dynamically change the color e.g. if we want to
add different themes. the background color for these elements are
white already anyway, so just remove them here.

Signed-off-by: Stefan Sterz <s.sterz@proxmox.com>
2023-03-08 17:55:41 +01:00
Thomas Lamprecht
dd604328aa ui: node config: code cleanups
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2023-02-22 16:16:37 +01:00
Thomas Lamprecht
44705bf65c ui: fix capability check for when to disable bulk migrate
In the resource tree context menu and in the node panel.

Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2023-02-22 16:15:50 +01:00
Lukas Wagner
ab78e7e2d0 ui: node options: make text for wakeonlan option a bit more descriptive
If one is not familiar with the underlying configuration option,
one might think that one can enable Wake-On-Lan for a node with this
option. It was not really clear (at least without RTFM ;) ) that a
MAC address is supposed to be entered here. The added text should
hopefully make this a bit more clear.

Also increased the label width a bit, so that a full MAC
address can be properly displayed.

Signed-off-by: Lukas Wagner <l.wagner@proxmox.com>
2023-01-24 16:13:43 +01:00
Thomas Lamprecht
04389e49d6 ui: factor out not found rendering to common helper
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2023-01-21 14:32:53 +01:00
Thomas Lamprecht
31fcdc1e8e fix #4194: ui: clarify that it's actually a bulk shutdown, not a stop
As some users where confused by the usage of "Stop", which we
normally reserve for a hard-stop.

And yes, while the bulk shutdown formerly always had a timeout armed
hard-stop hard coded, it was still subtle and we recently exposed
control on that via the API an UI, so use shutdown to be more in line
with the CT/VM naming, e.g., in their power menus.

Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2023-01-14 17:41:04 +01:00
Thomas Lamprecht
87f43acb8e ui: improve ZFS pool name validator accuracy
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2022-11-19 15:56:46 +01:00
Thomas Lamprecht
58de15074f ui: node disk manage: mark using ZFS reserved pool names as invalid
ZFS will die anyway later so catch this earlier for better UX

Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2022-11-18 18:27:56 +01:00
Thomas Lamprecht
2db62238ee ui: disk manage: move dRAID options into field set
to avoid an overly asymmetric form field balance

Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2022-11-17 19:29:21 +01:00
Thomas Lamprecht
049b783638 ui: disk manage: rework assembling dRAID options
Simply use onGetValues to assemble the dRAID config, if any.

We do not need to bother with setting values as this is only for
creates, never for edit/displays.

Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2022-11-17 19:14:08 +01:00
Stefan Hrdlicka
84cf9e4f4b fix #3967: enable ZFS dRAID creation in WebGUI
add fields for additional settings required by ZFS dRAID

Signed-off-by: Stefan Hrdlicka <s.hrdlicka@proxmox.com>
2022-11-17 18:47:23 +01:00
Fiona Ebner
cf6b65a292 ui: {guest, node} summary: use correct unit for CPU usage
One could also think about showing something like '% of N CPUs', but
this can be inaccurate for older data, because the number of CPUs can
change.

Reported in the community forum:
https://forum.proxmox.com/threads/117362/

Signed-off-by: Fiona Ebner <f.ebner@proxmox.com>
2022-11-07 11:20:59 +01:00
Thomas Lamprecht
2f9fc81190 ui: node: rework layout of certificate viewer
Move the raw cert into a fieldset and collapse that by default, also
make it render monospace and pre-wrap whitespace.

Use a inputpanel to get top, col 1/2 & bottom layout so that rsa key
type/size and validity range can be rendered more compactly

n addition to that limit the whole windows height but make it
scrollable, this allows to sanely use the viewer on certs with many
SANs even on small window/browser sizes.

Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2022-10-19 15:14:18 +02:00
Thomas Lamprecht
d3d4873615 ui: node certificate: make panel only vertical scrollable
Otherwise, a browser window breaks the responsive horizontal
flex-flow/grid-column resize, and just displays the vertical scroll
bar instead, which can look a bit odd.

Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2022-10-10 16:28:28 +02:00
Dominik Csapak
6a594c50cb ui: node certificate: make parent panel scrollable
The `ACME` panel may be rendered out of sight (overflow) when there
are enough SANs on the upper `Certificates` panel to push it down
enough and the browser/display height is too small.

Enable the `scrollable` config for the parent certificate view panel
to make ExtJS automatically add a scrollbar if the content overflows.

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2022-10-10 16:28:28 +02:00
Fabian Grünbichler
dc17baee74 www: subscription: add Signed/Offline status
Signed-off-by: Fabian Grünbichler <f.gruenbichler@proxmox.com>
2022-09-06 11:02:59 +02:00
Thomas Lamprecht
1992003e00 ui: move new node options below hosts entry
avoid splitting the related DNS and Hosts settings in the middle

Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2022-05-12 16:40:41 +02:00
Daniel Tschlatscher
5837726350 fix #3994: ui: add Options entry in the node System menu
Add the subentry "Options" in the "System" menu to expose some
options in the GUI which were not exposed before.

Added a new file for displaying and editing the node config options
which were not exposed through the GUI yet. Namely those are the
settings for wakeonlan and startall-on-boot-delay. Edited the
Makefile to include the newly created file.

Signed-off-by: Daniel Tschlatscher <d.tschlatscher@proxmox.com>
2022-05-12 16:38:07 +02:00
Stefan Sterz
742de03d5a ui: move NotesView panel and NotesEdit window to widget kit
this removes the NotesView panel and NotesEdit and replaces them with
with the version from the widget kit. requires a bump of the widget
toolkit.

Signed-off-by: Stefan Sterz <s.sterz@proxmox.com>
2022-04-13 11:35:30 +02:00
Fabian Ebner
85df37251f ui: lvm: better convey space information
Namely, that it's just assigned/reserved space, not necessarily
actively used. Selection of forum threads about this confusion (of
dozens more):

https://forum.proxmox.com/threads/93820/
https://forum.proxmox.com/threads/52899/
https://forum.proxmox.com/threads/52929/

Signed-off-by: Fabian Ebner <f.ebner@proxmox.com>
2022-01-28 12:03:20 +01:00
Fabian Ebner
545f94e7d2 ui: node: zfs: use ZFSDetail window from widget-toolkit
The only functional differences I could see are the missing
defaultValue for 'Scan' and the reduced height. For restoring the
height, there is a proposed patch for widget-toolkit.

Signed-off-by: Fabian Ebner <f.ebner@proxmox.com>
2022-01-13 12:54:03 +01:00
Fabian Ebner
392e3cf11d sorters: use correct property 'direction' and keep default 'ASC'
Ext.util.Sorter does not have an 'order' property, so 'order: DESC'
didn't have an effect. The default is 'ASC' and it is arguably the
preferred direction for all affected sorters anyways.

Signed-off-by: Fabian Ebner <f.ebner@proxmox.com>
2021-12-16 10:11:48 +01:00
Fabian Ebner
6c356c927b partially fix #2285: ui: disk create: allow selecting partitions
Signed-off-by: Fabian Ebner <f.ebner@proxmox.com>
2021-11-11 21:51:04 +01:00