fix #4393: ui: storage backup view: make pbs-specific columns sortable

The sort order is analogous to how it behaves in the datastore content
overview in pbs.

This means sorting in ascending order behaves as follows:

Verify State
* failed
* none
* ok

Encryption
* no
* yes

For the encryption state there is theoretically a distinction between
signed and encrypted, but as far as I can tell we do not render this
distinction in PVE, which is why I chose to not make this distinction
for sorting as well.

Signed-off-by: Stefan Hanreich <s.hanreich@proxmox.com>
This commit is contained in:
Stefan Hanreich 2022-12-16 13:45:06 +01:00 committed by Thomas Lamprecht
parent 485e510694
commit fdde857a89
2 changed files with 19 additions and 0 deletions

View File

@ -1963,6 +1963,13 @@ Ext.define('PVE.Utils', {
},
tagCharRegex: /^[a-z0-9+_.-]+$/i,
verificationStateOrder: {
'failed': 0,
'none': 1,
'ok': 2,
'__default__': 3,
},
},
singleton: true,

View File

@ -197,11 +197,23 @@ Ext.define('PVE.storage.BackupView', {
header: gettext('Encrypted'),
dataIndex: 'encrypted',
renderer: PVE.Utils.render_backup_encryption,
sorter: {
property: 'encrypted',
transform: (value) => value ? 1 : 0,
},
},
verification: {
header: gettext('Verify State'),
dataIndex: 'verification',
renderer: PVE.Utils.render_backup_verification,
sorter: {
property: 'verification',
transform: (value) => {
let state = value?.state ?? 'none';
let order = PVE.Utils.verificationStateOrder;
return order[state] ?? order.__default__;
},
},
},
};
}