proxmox-mirrors/pve-manager
1
0
Fork 0
mirror of https://git.proxmox.com/git/pve-manager synced 2025-08-13 21:24:01 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

ui: qemu/HardwareView: eslint: enforce "no-shadow" rule

Browse Source 
By removing global vars 'i' and 'confid' and declaring them with let in the needed
context.

'i' wasn't necessary but had to be touched anyway.

Signed-off-by: Aaron Lauterer <a.lauterer@proxmox.com>
This commit is contained in:
Aaron Lauterer 2021-02-12 16:57:49 +01:00 committed by Thomas Lamprecht
parent 87f53aa85e
commit f8205155e9
1 changed files with 12 additions and 13 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

25
www/manager6/qemu/HardwareView.js
View File

@ -45,7 +45,6 @@ Ext.define('PVE.qemu.HardwareView', {
initComponent: function() { initComponent: function() {
var me = this; var me = this;
var i, confid;
var nodename = me.pveSelNode.data.node; var nodename = me.pveSelNode.data.node;
if (!nodename) { if (!nodename) {
@ -220,7 +219,7 @@ Ext.define('PVE.qemu.HardwareView', {
}; };
PVE.Utils.forEachBus(undefined, function(type, id) { PVE.Utils.forEachBus(undefined, function(type, id) {
var confid = type + id; let confid = type + id;
rows[confid] = { rows[confid] = {
group: 10, group: 10,
iconCls: 'hdd-o', iconCls: 'hdd-o',
@ -232,8 +231,8 @@ Ext.define('PVE.qemu.HardwareView', {
cloudheader: gettext('CloudInit Drive') + ' (' + confid + ')', cloudheader: gettext('CloudInit Drive') + ' (' + confid + ')',
}; };
}); });
for (i = 0; i < PVE.Utils.hardware_counts.net; i++) { for (let i = 0; i < PVE.Utils.hardware_counts.net; i++) {
confid = "net" + i.toString(); let confid = "net" + i.toString();
rows[confid] = { rows[confid] = {
group: 15, group: 15,
order: i, order: i,
@ -250,8 +249,8 @@ Ext.define('PVE.qemu.HardwareView', {
never_delete: !caps.vms['VM.Config.Disk'], never_delete: !caps.vms['VM.Config.Disk'],
header: gettext('EFI Disk'), header: gettext('EFI Disk'),
}; };
for (i = 0; i < PVE.Utils.hardware_counts.usb; i++) { for (let i = 0; i < PVE.Utils.hardware_counts.usb; i++) {
confid = "usb" + i.toString(); let confid = "usb" + i.toString();
rows[confid] = { rows[confid] = {
group: 25, group: 25,
order: i, order: i,
@ -261,8 +260,8 @@ Ext.define('PVE.qemu.HardwareView', {
header: gettext('USB Device') + ' (' + confid + ')', header: gettext('USB Device') + ' (' + confid + ')',
}; };
} }
for (i = 0; i < PVE.Utils.hardware_counts.hostpci; i++) { for (let i = 0; i < PVE.Utils.hardware_counts.hostpci; i++) {
confid = "hostpci" + i.toString(); let confid = "hostpci" + i.toString();
rows[confid] = { rows[confid] = {
group: 30, group: 30,
order: i, order: i,
@ -272,8 +271,8 @@ Ext.define('PVE.qemu.HardwareView', {
header: gettext('PCI Device') + ' (' + confid + ')', header: gettext('PCI Device') + ' (' + confid + ')',
}; };
} }
for (i = 0; i < PVE.Utils.hardware_counts.serial; i++) { for (let i = 0; i < PVE.Utils.hardware_counts.serial; i++) {
confid = "serial" + i.toString(); let confid = "serial" + i.toString();
rows[confid] = { rows[confid] = {
group: 35, group: 35,
order: i, order: i,
@ -289,7 +288,7 @@ Ext.define('PVE.qemu.HardwareView', {
never_delete: !caps.vms['VM.Config.HWType'], never_delete: !caps.vms['VM.Config.HWType'],
header: gettext('Audio Device'), header: gettext('Audio Device'),
}; };
for (i = 0; i < 256; i++) { for (let i = 0; i < 256; i++) {
rows["unused" + i.toString()] = { rows["unused" + i.toString()] = {
group: 99, group: 99,
order: i, order: i,
@ -531,8 +530,8 @@ Ext.define('PVE.qemu.HardwareView', {
let isAtLimit = (type) => counts[type] >= PVE.Utils.hardware_counts[type]; let isAtLimit = (type) => counts[type] >= PVE.Utils.hardware_counts[type];
var set_button_status = function() { var set_button_status = function() {
var sm = me.getSelectionModel(); var selection_model = me.getSelectionModel();
var rec = sm.getSelection()[0]; var rec = selection_model.getSelection()[0];
// en/disable hardwarebuttons // en/disable hardwarebuttons
counts = {}; counts = {};