proxmox-mirrors/pve-manager
1
0
Fork 0
mirror of https://git.proxmox.com/git/pve-manager synced 2025-08-05 16:18:25 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

comestic : switch proto and interface in forms

Browse Source 
for readability, better to have

macro
proto
src port
dest port

in same column

Signed-off-by: Alexandre Derumier <aderumier@odiso.com>
This commit is contained in:
Alexandre Derumier 2014-05-19 05:42:21 +02:00 committed by Dietmar Maurer
parent ad1072cd11
commit f6f18eed76
1 changed files with 33 additions and 33 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

66
www/manager/grid/FirewallRules.js
View File

@ -70,18 +70,27 @@ Ext.define('PVE.FirewallRulePanel', {
data: [['ACCEPT', 'ACCEPT'], ['DROP', 'DROP'], ['REJECT', 'REJECT']],
fieldLabel: gettext('Action'),
allowBlank: false
},
{
xtype: 'pveKVComboBox',
name: 'proto',
value: '',
}
];
if (me.allow_iface) {
me.column1.push({
xtype: 'pvetextfield',
name: 'iface',
deleteEmpty: !me.create,
emptyText: 'any',
editable: true,
data: [['tcp', 'TCP'], ['udp', 'UDP'], ['icmp', 'ICMP']],
fieldLabel: gettext('Protocol'),
allowBlank: true
},
value: '',
fieldLabel: gettext('Interface')
});
} else {
me.column1.push({
xtype: 'displayfield',
fieldLabel: '',
height: 22, // hack: set same height as text fields
value: ''
});
}
me.column1.push([
{
xtype: 'displayfield',
fieldLabel: '',
@ -106,7 +115,7 @@ Ext.define('PVE.FirewallRulePanel', {
value: '',
fieldLabel: gettext('Destination')
}
];
]);
me.column2 = [
{
@ -124,27 +133,18 @@ Ext.define('PVE.FirewallRulePanel', {
deleteEmpty: !me.create,
fieldLabel: gettext('Macro'),
allowBlank: true
}
];
if (me.allow_iface) {
me.column2.push({
xtype: 'pvetextfield',
name: 'iface',
deleteEmpty: !me.create,
},
{
xtype: 'pveKVComboBox',
name: 'proto',
value: '',
fieldLabel: gettext('Interface')
});
} else {
me.column2.push({
xtype: 'displayfield',
fieldLabel: '',
height: 22, // hack: set same height as text fields
value: ''
});
}
me.column2.push([
deleteEmpty: !me.create,
emptyText: 'any',
editable: true,
data: [['tcp', 'TCP'], ['udp', 'UDP'], ['icmp', 'ICMP']],
fieldLabel: gettext('Protocol'),
allowBlank: true
},
{
xtype: 'displayfield',
fieldLabel: '',
@ -164,7 +164,7 @@ Ext.define('PVE.FirewallRulePanel', {
value: '',
fieldLabel: gettext('Dest. port')
}
]);
];
me.columnB = [
{