proxmox-mirrors/pve-manager
1
0
Fork 0
mirror of https://git.proxmox.com/git/pve-manager synced 2025-08-16 11:04:41 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

ui: eslint: enforce "no-unneeded-ternary" rule

Browse Source 
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
This commit is contained in:
Thomas Lamprecht 2021-01-19 17:41:11 +01:00
parent 8058410f40
commit ef725143c6
12 changed files with 29 additions and 29 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
www/manager6/Utils.js
View File

@ -1251,7 +1251,7 @@ Ext.define('PVE.Utils', {
// Note: we need to tell android the correct file name extension // Note: we need to tell android the correct file name extension
// but we do not set 'download' tag for other environments, because // but we do not set 'download' tag for other environments, because
// It can have strange side effects (additional user prompt on firefox) // It can have strange side effects (additional user prompt on firefox)
var andriod = navigator.userAgent.match(/Android/i) ? true : false; var andriod = !!navigator.userAgent.match(/Android/i);
if (andriod) { if (andriod) {
link.download = name; link.download = name;
} }
@ -1527,7 +1527,7 @@ Ext.define('PVE.Utils', {
if (Proxmox.UserName === 'root@pam') { if (Proxmox.UserName === 'root@pam') {
container.el.mask(); container.el.mask();
if (!container.down('pveCephInstallWindow')) { if (!container.down('pveCephInstallWindow')) {
var isInstalled = msg.match(/not initialized/i) ? true : false; var isInstalled = !!msg.match(/not initialized/i);
var win = Ext.create('PVE.ceph.Install', { var win = Ext.create('PVE.ceph.Install', {
nodename: nodename, nodename: nodename,
}); });

4
www/manager6/dc/Backup.js
View File

@ -212,14 +212,14 @@ Ext.define('PVE.dc.BackupEdit', {
xtype: 'pveEmailNotificationSelector', xtype: 'pveEmailNotificationSelector',
fieldLabel: gettext('Email notification'), fieldLabel: gettext('Email notification'),
name: 'mailnotification', name: 'mailnotification',
deleteEmpty: me.isCreate ? false : true, deleteEmpty: !me.isCreate,
value: me.isCreate ? 'always' : '', value: me.isCreate ? 'always' : '',
}, },
{ {
xtype: 'pveCompressionSelector', xtype: 'pveCompressionSelector',
fieldLabel: gettext('Compression'), fieldLabel: gettext('Compression'),
name: 'compress', name: 'compress',
deleteEmpty: me.isCreate ? false : true, deleteEmpty: !me.isCreate,
value: 'zstd', value: 'zstd',
}, },
{ {

2
www/manager6/dc/UserEdit.js
View File

@ -73,7 +73,7 @@ Ext.define('PVE.dc.UserEdit', {
value: me.userid, value: me.userid,
renderer: Ext.String.htmlEncode, renderer: Ext.String.htmlEncode,
allowBlank: false, allowBlank: false,
submitValue: me.isCreate ? true : false, submitValue: !!me.isCreate,
}, },
pwfield, verifypw, pwfield, verifypw,
{ {

4
www/manager6/lxc/Config.js
View File

@ -109,7 +109,7 @@ Ext.define('PVE.lxc.Config', {
{ {
text: gettext('Clone'), text: gettext('Clone'),
iconCls: 'fa fa-fw fa-clone', iconCls: 'fa fa-fw fa-clone',
hidden: caps.vms['VM.Clone'] ? false : true, hidden: !caps.vms['VM.Clone'],
handler: function() { handler: function() {
PVE.window.Clone.wrap(nodename, vmid, template, 'lxc'); PVE.window.Clone.wrap(nodename, vmid, template, 'lxc');
}, },
@ -119,7 +119,7 @@ Ext.define('PVE.lxc.Config', {
disabled: template, disabled: template,
xtype: 'pveMenuItem', xtype: 'pveMenuItem',
iconCls: 'fa fa-fw fa-file-o', iconCls: 'fa fa-fw fa-file-o',
hidden: caps.vms['VM.Allocate'] ? false : true, hidden: !caps.vms['VM.Allocate'],
confirmMsg: Proxmox.Utils.format_task_description('vztemplate', vmid), confirmMsg: Proxmox.Utils.format_task_description('vztemplate', vmid),
handler: function() { handler: function() {
Proxmox.Utils.API2Request({ Proxmox.Utils.API2Request({

2
www/manager6/qemu/CDEdit.js
View File

@ -159,7 +159,7 @@ Ext.define('PVE.qemu.CDEdit', {
throw "no node name specified"; throw "no node name specified";
} }
me.isCreate = me.confid ? false : true; me.isCreate = !me.confid;
var ipanel = Ext.create('PVE.qemu.CDInputPanel', { var ipanel = Ext.create('PVE.qemu.CDInputPanel', {
confid: me.confid, confid: me.confid,

8
www/manager6/qemu/Config.js
View File

@ -85,7 +85,7 @@ Ext.define('PVE.qemu.Config', {
{ {
text: gettext('Clone'), text: gettext('Clone'),
iconCls: 'fa fa-fw fa-clone', iconCls: 'fa fa-fw fa-clone',
hidden: caps.vms['VM.Clone'] ? false : true, hidden: !caps.vms['VM.Clone'],
handler: function() { handler: function() {
PVE.window.Clone.wrap(nodename, vmid, template, 'qemu'); PVE.window.Clone.wrap(nodename, vmid, template, 'qemu');
}, },
@ -95,7 +95,7 @@ Ext.define('PVE.qemu.Config', {
disabled: template, disabled: template,
xtype: 'pveMenuItem', xtype: 'pveMenuItem',
iconCls: 'fa fa-fw fa-file-o', iconCls: 'fa fa-fw fa-file-o',
hidden: caps.vms['VM.Allocate'] ? false : true, hidden: !caps.vms['VM.Allocate'],
confirmMsg: Proxmox.Utils.format_task_description('qmtemplate', vmid), confirmMsg: Proxmox.Utils.format_task_description('qmtemplate', vmid),
handler: function() { handler: function() {
Proxmox.Utils.API2Request({ Proxmox.Utils.API2Request({
@ -389,8 +389,8 @@ Ext.define('PVE.qemu.Config', {
rec = s.data.get('lock'); rec = s.data.get('lock');
lock = rec ? rec.data.value : undefined; lock = rec ? rec.data.value : undefined;
spice = s.data.get('spice') ? true : false; spice = !!s.data.get('spice');
xtermjs = s.data.get('serial') ? true : false; xtermjs = !!s.data.get('serial');
} }
if (template) { if (template) {

16
www/manager6/qemu/HardwareView.js
View File

@ -225,7 +225,7 @@ Ext.define('PVE.qemu.HardwareView', {
group: 10, group: 10,
iconCls: 'hdd-o', iconCls: 'hdd-o',
editor: 'PVE.qemu.HDEdit', editor: 'PVE.qemu.HDEdit',
never_delete: caps.vms['VM.Config.Disk'] ? false : true, never_delete: !caps.vms['VM.Config.Disk'],
isOnStorageBus: true, isOnStorageBus: true,
header: gettext('Hard Disk') + ' (' + confid +')', header: gettext('Hard Disk') + ' (' + confid +')',
cdheader: gettext('CD/DVD Drive') + ' (' + confid +')', cdheader: gettext('CD/DVD Drive') + ' (' + confid +')',
@ -239,7 +239,7 @@ Ext.define('PVE.qemu.HardwareView', {
order: i, order: i,
iconCls: 'exchange', iconCls: 'exchange',
editor: caps.vms['VM.Config.Network'] ? 'PVE.qemu.NetworkEdit' : undefined, editor: caps.vms['VM.Config.Network'] ? 'PVE.qemu.NetworkEdit' : undefined,
never_delete: caps.vms['VM.Config.Network'] ? false : true, never_delete: !caps.vms['VM.Config.Network'],
header: gettext('Network Device') + ' (' + confid +')', header: gettext('Network Device') + ' (' + confid +')',
}; };
} }
@ -247,7 +247,7 @@ Ext.define('PVE.qemu.HardwareView', {
group: 20, group: 20,
iconCls: 'hdd-o', iconCls: 'hdd-o',
editor: null, editor: null,
never_delete: caps.vms['VM.Config.Disk'] ? false : true, never_delete: !caps.vms['VM.Config.Disk'],
header: gettext('EFI Disk'), header: gettext('EFI Disk'),
}; };
for (i = 0; i < PVE.Utils.hardware_counts.usb; i++) { for (i = 0; i < PVE.Utils.hardware_counts.usb; i++) {
@ -257,7 +257,7 @@ Ext.define('PVE.qemu.HardwareView', {
order: i, order: i,
iconCls: 'usb', iconCls: 'usb',
editor: caps.nodes['Sys.Console'] ? 'PVE.qemu.USBEdit' : undefined, editor: caps.nodes['Sys.Console'] ? 'PVE.qemu.USBEdit' : undefined,
never_delete: caps.nodes['Sys.Console'] ? false : true, never_delete: !caps.nodes['Sys.Console'],
header: gettext('USB Device') + ' (' + confid + ')', header: gettext('USB Device') + ' (' + confid + ')',
}; };
} }
@ -267,7 +267,7 @@ Ext.define('PVE.qemu.HardwareView', {
group: 30, group: 30,
order: i, order: i,
tdCls: 'pve-itype-icon-pci', tdCls: 'pve-itype-icon-pci',
never_delete: caps.nodes['Sys.Console'] ? false : true, never_delete: !caps.nodes['Sys.Console'],
editor: caps.nodes['Sys.Console'] ? 'PVE.qemu.PCIEdit' : undefined, editor: caps.nodes['Sys.Console'] ? 'PVE.qemu.PCIEdit' : undefined,
header: gettext('PCI Device') + ' (' + confid + ')', header: gettext('PCI Device') + ' (' + confid + ')',
}; };
@ -278,7 +278,7 @@ Ext.define('PVE.qemu.HardwareView', {
group: 35, group: 35,
order: i, order: i,
tdCls: 'pve-itype-icon-serial', tdCls: 'pve-itype-icon-serial',
never_delete: caps.nodes['Sys.Console'] ? false : true, never_delete: !caps.nodes['Sys.Console'],
header: gettext('Serial Port') + ' (' + confid + ')', header: gettext('Serial Port') + ' (' + confid + ')',
}; };
} }
@ -286,7 +286,7 @@ Ext.define('PVE.qemu.HardwareView', {
group: 40, group: 40,
iconCls: 'volume-up', iconCls: 'volume-up',
editor: caps.vms['VM.Config.HWType'] ? 'PVE.qemu.AudioEdit' : undefined, editor: caps.vms['VM.Config.HWType'] ? 'PVE.qemu.AudioEdit' : undefined,
never_delete: caps.vms['VM.Config.HWType'] ? false : true, never_delete: !caps.vms['VM.Config.HWType'],
header: gettext('Audio Device'), header: gettext('Audio Device'),
}; };
for (i = 0; i < 256; i++) { for (i = 0; i < 256; i++) {
@ -303,7 +303,7 @@ Ext.define('PVE.qemu.HardwareView', {
group: 45, group: 45,
tdCls: 'pve-itype-icon-die', tdCls: 'pve-itype-icon-die',
editor: caps.nodes['Sys.Console'] ? 'PVE.qemu.RNGEdit' : undefined, editor: caps.nodes['Sys.Console'] ? 'PVE.qemu.RNGEdit' : undefined,
never_delete: caps.nodes['Sys.Console'] ? false : true, never_delete: !caps.nodes['Sys.Console'],
header: gettext("VirtIO RNG"), header: gettext("VirtIO RNG"),
}; };

2
www/manager6/qemu/IPConfigEdit.js
View File

@ -202,7 +202,7 @@ Ext.define('PVE.qemu.IPConfigEdit', {
throw "no node name specified"; throw "no node name specified";
} }
me.isCreate = me.confid ? false : true; me.isCreate = !me.confid;
var ipanel = Ext.create('PVE.qemu.IPConfigPanel', { var ipanel = Ext.create('PVE.qemu.IPConfigPanel', {
confid: me.confid, confid: me.confid,

2
www/manager6/qemu/NetworkEdit.js
View File

@ -180,7 +180,7 @@ Ext.define('PVE.qemu.NetworkEdit', {
throw "no node name specified"; throw "no node name specified";
} }
me.isCreate = me.confid ? false : true; me.isCreate = !me.confid;
var ipanel = Ext.create('PVE.qemu.NetworkInputPanel', { var ipanel = Ext.create('PVE.qemu.NetworkInputPanel', {
confid: me.confid, confid: me.confid,

2
www/manager6/storage/IScsiEdit.js
View File

@ -71,7 +71,7 @@ Ext.define('PVE.storage.IScsiInputPanel', {
}, },
setValues: function(values) { setValues: function(values) {
values.luns = (values.content.indexOf('images') !== -1) ? true : false; values.luns = (values.content.indexOf('images') !== -1);
this.callParent([values]); this.callParent([values]);
}, },

8
www/manager6/window/Clone.js
View File

@ -29,8 +29,8 @@ Ext.define('PVE.window.Clone', {
}, },
success: function(response, opts) { success: function(response, opts) {
var snapshotList = response.result.data; var snapshotList = response.result.data;
var hasSnapshots = snapshotList.length === 1 && var hasSnapshots = !(snapshotList.length === 1 &&
snapshotList[0].name === 'current' ? false : true; snapshotList[0].name === 'current');
Ext.create('PVE.window.Clone', { Ext.create('PVE.window.Clone', {
nodename: nodename, nodename: nodename,
@ -227,7 +227,7 @@ Ext.define('PVE.window.Clone', {
nodename: me.nodename, nodename: me.nodename,
guestType: me.guestType, guestType: me.guestType,
vmid: me.vmid, vmid: me.vmid,
hidden: me.isTemplate || !me.hasSnapshots ? true : false, hidden: !!(me.isTemplate || !me.hasSnapshots),
disabled: false, disabled: false,
allowBlank: false, allowBlank: false,
value: me.snapname, value: me.snapname,
@ -248,7 +248,7 @@ Ext.define('PVE.window.Clone', {
allowBlank: true, allowBlank: true,
storageContent: me.guestType === 'qemu' ? 'images' : 'rootdir', storageContent: me.guestType === 'qemu' ? 'images' : 'rootdir',
emptyText: gettext('Same as source'), emptyText: gettext('Same as source'),
disabled: me.isTemplate ? true : false, // because default mode is clone for templates disabled: !!me.isTemplate, // because default mode is clone for templates
}); });
var formPanel = Ext.create('Ext.form.Panel', { var formPanel = Ext.create('Ext.form.Panel', {

4
www/manager6/window/SafeDestroy.js
View File

@ -70,8 +70,8 @@ Ext.define('PVE.window.SafeDestroy', {
Ext.Msg.alert('Error', response.htmlStatus); Ext.Msg.alert('Error', response.htmlStatus);
}, },
success: function(response, options) { success: function(response, options) {
var hasProgressBar = view.showProgress && var hasProgressBar = !!(view.showProgress &&
response.result.data ? true : false; response.result.data);
if (hasProgressBar) { if (hasProgressBar) {
// stay around so we can trigger our close events // stay around so we can trigger our close events