From ee3903451ebeeea763f2669f647b126062a1d785 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Dominic=20J=C3=A4ger?= Date: Wed, 19 May 2021 12:56:18 +0200 Subject: [PATCH] ui: panel/ConfigPanel: eslint fixes MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Signed-off-by: Dominic Jäger --- www/manager6/panel/ConfigPanel.js | 15 ++++++++------- 1 file changed, 8 insertions(+), 7 deletions(-) diff --git a/www/manager6/panel/ConfigPanel.js b/www/manager6/panel/ConfigPanel.js index 23a6ee58..788615aa 100644 --- a/www/manager6/panel/ConfigPanel.js +++ b/www/manager6/panel/ConfigPanel.js @@ -68,11 +68,11 @@ Ext.define('PVE.panel.Config', { singleExpand: false, listeners: { selectionchange: function(treeList, selection) { - var me = this.up('panel'); - me.suspendLayout = true; - me.activateCard(selection.data.id); - me.suspendLayout = false; - me.updateLayout(); + let view = this.up('panel'); + view.suspendLayout = true; + view.activateCard(selection.data.id); + view.suspendLayout = false; + view.updateLayout(); }, itemclick: function(treelist, info) { var olditem = treelist.getSelection(); @@ -123,6 +123,7 @@ Ext.define('PVE.panel.Config', { menu.setSelection(selection); return cardid; } + return ''; }, activateCard: function(cardid) { @@ -160,7 +161,7 @@ Ext.define('PVE.panel.Config', { var activeTab; // leaving this undefined means items[0] will be the default tab if (stateid) { - var state = me.sp.get(stateid); + let state = me.sp.get(stateid); if (state && state.value) { // if this tab does not exist, it chooses the first activeTab = state.value; @@ -259,7 +260,7 @@ Ext.define('PVE.panel.Config', { var acard = me.getLayout().getActiveItem().itemId; // get the itemid of the new value var ncard = state.value || me.firstItem; - if (ncard && acard != ncard) { + if (ncard && acard !== ncard) { // select the chosen item menu.setSelection(root.findChild('id', ncard, true) || root.firstChild); }