ui: snapshot tree: eslint fixes and code cleanup/refactoring/modernize

Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
This commit is contained in:
Thomas Lamprecht 2021-05-19 14:17:50 +02:00
parent 90519f8a55
commit eda300438e

View File

@ -286,11 +286,8 @@ Ext.define('PVE.guest.SnapshotTree', {
}, },
confirmMsg: function() { confirmMsg: function() {
let view = this.up('treepanel'); let view = this.up('treepanel');
let rec = view.getSelection()[0]; let { data } = view.getSelection()[0];
return Ext.String.format( return Ext.String.format(gettext('Are you sure you want to remove entry {0}'), `'${data.name}'`);
gettext('Are you sure you want to remove entry {0}'),
`'${rec.data.name}'`,
);
}, },
handler: 'remove', handler: 'remove',
}, },
@ -307,7 +304,11 @@ Ext.define('PVE.guest.SnapshotTree', {
columnLines: true, columnLines: true,
fields: [ fields: [
'name', 'description', 'snapstate', 'vmstate', 'running', 'name',
'description',
'snapstate',
'vmstate',
'running',
{ name: 'snaptime', type: 'date', dateFormat: 'timestamp' }, { name: 'snaptime', type: 'date', dateFormat: 'timestamp' },
{ {
name: 'order', name: 'order',
@ -323,13 +324,7 @@ Ext.define('PVE.guest.SnapshotTree', {
text: gettext('Name'), text: gettext('Name'),
dataIndex: 'name', dataIndex: 'name',
width: 200, width: 200,
renderer: function(value, metaData, record) { renderer: (value, _, { data }) => data.name !== 'current' ? value : gettext('NOW'),
if (value === 'current') {
return gettext('NOW');
} else {
return value;
}
},
}, },
{ {
text: gettext('RAM'), text: gettext('RAM'),
@ -341,11 +336,7 @@ Ext.define('PVE.guest.SnapshotTree', {
resizable: false, resizable: false,
dataIndex: 'vmstate', dataIndex: 'vmstate',
width: 50, width: 50,
renderer: function(value, metaData, record) { renderer: (value, _, { data }) => data.name !== 'current' ? Proxmox.Utils.format_boolean(value) : '',
if (record.data.name !== 'current') {
return Proxmox.Utils.format_boolean(value);
}
},
}, },
{ {
text: gettext('Date') + "/" + gettext("Status"), text: gettext('Date') + "/" + gettext("Status"),
@ -354,10 +345,10 @@ Ext.define('PVE.guest.SnapshotTree', {
renderer: function(value, metaData, record) { renderer: function(value, metaData, record) {
if (record.data.snapstate) { if (record.data.snapstate) {
return record.data.snapstate; return record.data.snapstate;
} } else if (value) {
if (value) {
return Ext.Date.format(value, 'Y-m-d H:i:s'); return Ext.Date.format(value, 'Y-m-d H:i:s');
} }
return '';
}, },
}, },
{ {