From ecc08c34ea99c2211be078c89a8301a9a8bdf69f Mon Sep 17 00:00:00 2001 From: Fabian Ebner Date: Fri, 15 Jan 2021 13:49:05 +0100 Subject: [PATCH] vzdump: avoid parsing already parsed option When a job is updated, verify_vzdump_parameters() is called twice. This led to parse_property_string being called with the already parsed option. Reported on the pve-user mailing list: https://lists.proxmox.com/pipermail/pve-user/2021-January/172258.html Signed-off-by: Fabian Ebner --- PVE/VZDump.pm | 1 + 1 file changed, 1 insertion(+) diff --git a/PVE/VZDump.pm b/PVE/VZDump.pm index d6f9709b..a99d0565 100644 --- a/PVE/VZDump.pm +++ b/PVE/VZDump.pm @@ -79,6 +79,7 @@ my $parse_prune_backups_maxfiles = sub { if defined($maxfiles) && defined($prune_backups); if (defined($prune_backups)) { + return if ref($prune_backups) eq 'HASH'; # already parsed $param->{'prune-backups'} = PVE::JSONSchema::parse_property_string( 'prune-backups', $prune_backups