proxmox-mirrors/pve-manager
1
0
Fork 0
mirror of https://git.proxmox.com/git/pve-manager synced 2025-07-27 03:55:33 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

ui: only allow rbd pools to be added as rbd storage

Browse Source 
previously the ui would allow adding all pools (even the default
ceph-mon pools) as storage. this could lead to issues when users did
use these pools as storage (e.g.: vms missing their disks after a
migration). hence, restrict the pool selector to rbd pools.

fails gracefully by reverting to the previous behavior if a pool has
no application assigned to it.

Signed-off-by: Stefan Sterz <s.sterz@proxmox.com>
Tested-By:  Aaron Lauterer <a.lauterer@proxmox.com>
This commit is contained in:
Stefan Sterz 2022-10-25 10:10:46 +02:00 committed by Thomas Lamprecht
parent 7818083008
commit eba38fa4b2
1 changed files with 10 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
www/manager6/form/CephPoolSelector.js
View File

@ -15,9 +15,15 @@ Ext.define('PVE.form.CephPoolSelector', {
throw "no nodename given";
}
let onlyRBDPools = ({ data }) =>
!data?.application_metadata || !!data?.application_metadata?.rbd;
var store = Ext.create('Ext.data.Store', {
fields: ['name'],
sorters: 'name',
filters: [
onlyRBDPools,
],
proxy: {
type: 'proxmox',
url: '/api2/json/nodes/' + me.nodename + '/ceph/pools',
@ -32,8 +38,10 @@ Ext.define('PVE.form.CephPoolSelector', {
store.load({
callback: function(rec, op, success) {
if (success && rec.length > 0) {
me.select(rec[0]);
let filteredRec = rec.filter(onlyRBDPools);
if (success && filteredRec.length > 0) {
me.select(filteredRec[0]);
}
},
});