From eb594f5ca56ccad1749ab68bac4e8f5a366e3b67 Mon Sep 17 00:00:00 2001 From: Thomas Lamprecht Date: Sat, 21 Nov 2020 20:43:08 +0100 Subject: [PATCH] ui: metrics: style cleanup: defined xtype first, name second those are both the most important for what the field is, so they should come first. Signed-off-by: Thomas Lamprecht --- www/manager6/dc/MetricServerView.js | 32 ++++++++++++++--------------- 1 file changed, 16 insertions(+), 16 deletions(-) diff --git a/www/manager6/dc/MetricServerView.js b/www/manager6/dc/MetricServerView.js index ff29f9cb..889b3d22 100644 --- a/www/manager6/dc/MetricServerView.js +++ b/www/manager6/dc/MetricServerView.js @@ -194,9 +194,9 @@ Ext.define('PVE.dc.InfluxDBEdit', { }, }, { - fieldLabel: gettext('Name'), xtype: 'pmxDisplayEditField', name: 'id', + fieldLabel: gettext('Name'), allowBlank: false, cbind: { editable: '{isCreate}', @@ -204,37 +204,37 @@ Ext.define('PVE.dc.InfluxDBEdit', { }, }, { - fieldLabel: gettext('Enabled'), xtype: 'checkbox', + name: 'enable', + fieldLabel: gettext('Enabled'), inputValue: 1, uncheckedValue: 0, checked: true, - name: 'enable', }, ], column2: [ { - fieldLabel: gettext('Server'), xtype: 'proxmoxtextfield', name: 'server', + fieldLabel: gettext('Server'), allowBlank: false, }, { - fieldLabel: gettext('Port'), xtype: 'proxmoxintegerfield', + name: 'port', + fieldLabel: gettext('Port'), minValue: 1, maximum: 65536, - name: 'port', allowBlank: false, }, ], advancedColumn2: [ { - fieldLabel: 'MTU', xtype: 'proxmoxintegerfield', name: 'mtu', + fieldLabel: 'MTU', minValue: 1, emptyText: '1500', submitEmpty: false, @@ -273,9 +273,9 @@ Ext.define('PVE.dc.GraphiteEdit', { }, }, { - fieldLabel: gettext('Name'), xtype: 'pmxDisplayEditField', name: 'id', + fieldLabel: gettext('Name'), allowBlank: false, cbind: { editable: '{isCreate}', @@ -283,28 +283,28 @@ Ext.define('PVE.dc.GraphiteEdit', { }, }, { - fieldLabel: gettext('Enabled'), xtype: 'checkbox', + name: 'enable', + fieldLabel: gettext('Enabled'), inputValue: 1, uncheckedValue: 0, checked: true, - name: 'enable', }, ], column2: [ { - fieldLabel: gettext('Server'), xtype: 'proxmoxtextfield', name: 'server', + fieldLabel: gettext('Server'), allowBlank: false, }, { - fieldLabel: gettext('Port'), xtype: 'proxmoxintegerfield', + name: 'port', + fieldLabel: gettext('Port'), minimum: 1, maximum: 65536, - name: 'port', allowBlank: false, }, { @@ -320,9 +320,9 @@ Ext.define('PVE.dc.GraphiteEdit', { advancedColumn1: [ { - fieldLabel: gettext('Protocol'), xtype: 'proxmoxKVComboBox', name: 'proto', + fieldLabel: gettext('Protocol'), value: '__default__', cbind: { deleteEmpty: '{!isCreate}', @@ -343,9 +343,9 @@ Ext.define('PVE.dc.GraphiteEdit', { advancedColumn2: [ { - fieldLabel: 'MTU', xtype: 'proxmoxintegerfield', name: 'mtu', + fieldLabel: 'MTU', minimum: 1, emptyText: '1500', submitEmpty: false, @@ -354,9 +354,9 @@ Ext.define('PVE.dc.GraphiteEdit', { }, }, { - fieldLabel: gettext('TCP Timeout'), xtype: 'proxmoxintegerfield', name: 'timeout', + fieldLabel: gettext('TCP Timeout'), disabled: true, cbind: { deleteEmpty: '{!isCreate}',