proxmox-mirrors/pve-manager
1
0
Fork 0
mirror of https://git.proxmox.com/git/pve-manager synced 2025-05-29 17:40:46 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

status/graphite: fix memory leak, avoid cyclic closure reference

Browse Source 
The data passed to this closure was never free'd, depending on the
count of VM/CTs one could get >1 MB of RSS (!) memory leaked per
statd status cycle update run...

We could also use Scalar::Util's weaken, to weak a copy of this
variable, but as a simple undef works lets do that with a comment..

Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
This commit is contained in:
Thomas Lamprecht 2019-11-19 09:11:45 +01:00
parent 1e4ae7d44c
commit db2ce4886c
1 changed files with 2 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
PVE/Status/Graphite.pm
View File

@ -141,6 +141,8 @@ sub assemble {
} }
}; };
$assemble_graphite_data->($data, $path); $assemble_graphite_data->($data, $path);
$assemble_graphite_data = undef; # avoid cyclic reference!
} }
PVE::JSONSchema::register_format('graphite-path', \&pve_verify_graphite_path); PVE::JSONSchema::register_format('graphite-path', \&pve_verify_graphite_path);