From daf74a20fd96bb8e9a418d9e06fea32a453ea5ff Mon Sep 17 00:00:00 2001 From: Fiona Ebner Date: Wed, 21 Jun 2023 17:02:01 +0200 Subject: [PATCH] pve7to8: avoid confusing warning about required setting 'storage' for vzdump It's required in the schema for notes-template and protected, but when parsing vzdump.conf, it shouldn't matter whether the storage parameter is set or not. The warning is ugly and users might interpret it as something that needs to be acted upon for the upgrade: parse error in '/etc/vzdump.conf' - 'storage': missing property - 'notes-template' requires this property\nmissing property - 'protected' requires this property Signed-off-by: Fiona Ebner (cherry picked from commit 517abd0cd28a613598e2a3a8d5d8d057578c14b6) Signed-off-by: Thomas Lamprecht --- PVE/CLI/pve7to8.pm | 2 ++ 1 file changed, 2 insertions(+) diff --git a/PVE/CLI/pve7to8.pm b/PVE/CLI/pve7to8.pm index c083b95e..29bb099d 100644 --- a/PVE/CLI/pve7to8.pm +++ b/PVE/CLI/pve7to8.pm @@ -614,6 +614,8 @@ sub check_backup_retention_settings { eval { my $confdesc = PVE::VZDump::Common::get_confdesc(); + # vzdump.conf by itself doesn't need to honor any 'requires' + delete $confdesc->{$_}->{requires} for keys $confdesc->%*; my $fn = "/etc/vzdump.conf"; my $raw = PVE::Tools::file_get_contents($fn);