From d8da55382a0761229fe00851ffb523dce53788bb Mon Sep 17 00:00:00 2001 From: Dominik Csapak Date: Mon, 4 Oct 2021 09:50:00 +0200 Subject: [PATCH] ui: resourcetree: move guest position on template creation we sort templates at the end normally, but if we convert a guest to a template, it was not moved in the tree add it to the list of attributes that are checked for a move Signed-off-by: Dominik Csapak Tested-By: Aaron Lauterer --- www/manager6/tree/ResourceTree.js | 8 +++----- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/www/manager6/tree/ResourceTree.js b/www/manager6/tree/ResourceTree.js index 3b883d23..be90d4f7 100644 --- a/www/manager6/tree/ResourceTree.js +++ b/www/manager6/tree/ResourceTree.js @@ -239,6 +239,8 @@ Ext.define('PVE.tree.ResourceTree', { } let groups = me.viewFilter.groups || []; + // explicitly check for node/template, as those are not always grouping attributes + let moveCheckAttrs = groups.concat(['node', 'template']); let filterfn = me.viewFilter.filterfn; let reselect = false; // for disappeared nodes @@ -251,16 +253,12 @@ Ext.define('PVE.tree.ResourceTree', { let changed = false, moved = false; if (item) { // test if any grouping attributes changed, catches migrated tree-nodes in server view too - for (const attr of groups) { + for (const attr of moveCheckAttrs) { if (item.data[attr] !== olditem.data[attr]) { moved = true; break; } } - // explicitly check for node, as node is not a grouping attribute in some views - if (!moved && item.data.node !== olditem.data.node) { - moved = true; - } // tree item has been updated for (const field of ['text', 'running', 'template', 'status', 'qmpstatus', 'hastate', 'lock']) {