proxmox-mirrors/pve-manager
1
0
Fork 0
mirror of https://git.proxmox.com/git/pve-manager synced 2025-05-17 16:29:07 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

allow to select gzip or lzop in vzdump

Browse Source 
lzop is much faster, and we use that by default now.
This commit is contained in:
Dietmar Maurer 2012-02-07 10:29:57 +01:00
parent 5b9ae5b7da
commit d7550e095e
4 changed files with 36 additions and 20 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

37
PVE/VZDump.pm
View File

@ -643,6 +643,20 @@ sub run_hook_script {
run_command ($logfd, $cmd); run_command ($logfd, $cmd);
} }
sub compressor_info {
my ($opt_compress) = @_;
if (!$opt_compress || $opt_compress eq '0') {
return undef;
} elsif ($opt_compress eq '1' || $opt_compress eq 'lzo') {
return ('lzop', 'lzo');
} elsif ($opt_compress eq 'gzip') {
return ('gzip', 'gz');
} else {
die "internal error - unknown compression option '$opt_compress'";
}
}
sub exec_backup_task { sub exec_backup_task {
my ($self, $task) = @_; my ($self, $task) = @_;
@ -675,7 +689,11 @@ sub exec_backup_task {
my $logfile = $task->{logfile} = "$opts->{dumpdir}/$basename.log"; my $logfile = $task->{logfile} = "$opts->{dumpdir}/$basename.log";
my $ext = $opts->{compress} ? '.tgz' : '.tar'; my $ext = '.tar';
my ($comp, $comp_ext) = compressor_info($opts->{compress});
if ($comp && $comp_ext) {
$ext .= ".${comp_ext}";
}
if ($opts->{stdout}) { if ($opts->{stdout}) {
$task->{tarfile} = '-'; $task->{tarfile} = '-';
@ -836,13 +854,13 @@ sub exec_backup_task {
if ($opts->{stdout}) { if ($opts->{stdout}) {
debugmsg ('info', "sending archive to stdout", $logfd); debugmsg ('info', "sending archive to stdout", $logfd);
$plugin->archive($task, $vmid, $task->{tmptar}); $plugin->archive($task, $vmid, $task->{tmptar}, $comp);
$self->run_hook_script ('backup-end', $task, $logfd); $self->run_hook_script ('backup-end', $task, $logfd);
return; return;
} }
debugmsg ('info', "creating archive '$task->{tarfile}'", $logfd); debugmsg ('info', "creating archive '$task->{tarfile}'", $logfd);
$plugin->archive ($task, $vmid, $task->{tmptar}); $plugin->archive($task, $vmid, $task->{tmptar}, $comp);
rename ($task->{tmptar}, $task->{tarfile}) || rename ($task->{tmptar}, $task->{tarfile}) ||
die "unable to rename '$task->{tmptar}' to '$task->{tarfile}'\n"; die "unable to rename '$task->{tmptar}' to '$task->{tarfile}'\n";
@ -861,7 +879,7 @@ sub exec_backup_task {
my $dir = $opts->{dumpdir}; my $dir = $opts->{dumpdir};
foreach my $fn (<$dir/${bkname}-*>) { foreach my $fn (<$dir/${bkname}-*>) {
next if $fn eq $task->{tarfile}; next if $fn eq $task->{tarfile};
if ($fn =~ m!/(${bkname}-(\d{4})_(\d{2})_(\d{2})-(\d{2})_(\d{2})_(\d{2})\.(tgz|tar))$!) { if ($fn =~ m!/(${bkname}-(\d{4})_(\d{2})_(\d{2})-(\d{2})_(\d{2})_(\d{2})\.(tgz|(tar(\.(gz|lzo))?)))$!) {
$fn = "$dir/$1"; # untaint $fn = "$dir/$1"; # untaint
my $t = timelocal ($7, $6, $5, $4, $3 - 1, $2 - 1900); my $t = timelocal ($7, $6, $5, $4, $3 - 1, $2 - 1900);
push @bklist, [$fn, $t]; push @bklist, [$fn, $t];
@ -877,7 +895,7 @@ sub exec_backup_task {
debugmsg ('info', "delete old backup '$d->[0]'", $logfd); debugmsg ('info', "delete old backup '$d->[0]'", $logfd);
unlink $d->[0]; unlink $d->[0];
my $logfn = $d->[0]; my $logfn = $d->[0];
$logfn =~ s/\.(tgz|tar)$/\.log/; $logfn =~ s/\.(tgz|(tar(\.(gz|lzo))?))$/\.log/;
unlink $logfn; unlink $logfn;
} }
} }
@ -954,7 +972,7 @@ sub exec_backup_task {
} }
sub exec_backup { sub exec_backup {
my ($rpcenv, $authuser, $self) = @_; my ($self, $rpcenv, $authuser) = @_;
my $opts = $self->{opts}; my $opts = $self->{opts};
@ -1048,10 +1066,11 @@ my $confdesc = {
default => 1, default => 1,
}, },
compress => { compress => {
type => 'boolean', type => 'string',
description => "Compress dump file (gzip).", description => "Compress dump file.",
optional => 1, optional => 1,
default => 0, enum => ['0', '1', 'gzip', 'lzo'],
default => 'lzo',
}, },
quiet => { quiet => {
type => 'boolean', type => 'boolean',

15
PVE/VZDump/OpenVZ.pm
View File

@ -231,7 +231,7 @@ sub assemble {
} }
sub archive { sub archive {
my ($self, $task, $vmid, $filename) = @_; my ($self, $task, $vmid, $filename, $comp) = @_;
my $findexcl = $self->{vzdump}->{findexcl}; my $findexcl = $self->{vzdump}->{findexcl};
my $findargs = join (' ', @$findexcl) . ' -print0'; my $findargs = join (' ', @$findexcl) . ' -print0';
@ -240,8 +240,6 @@ sub archive {
my $srcdir = $self->{vmlist}->{$vmid}->{dir}; my $srcdir = $self->{vmlist}->{$vmid}->{dir};
my $snapdir = $task->{snapdir}; my $snapdir = $task->{snapdir};
my $zflag = $opts->{compress} ? 'z' : '';
my $taropts = "--totals --sparse --numeric-owner --no-recursion --ignore-failed-read --one-file-system"; my $taropts = "--totals --sparse --numeric-owner --no-recursion --ignore-failed-read --one-file-system";
# note: --remove-files does not work because we do not # note: --remove-files does not work because we do not
@ -253,13 +251,12 @@ sub archive {
#} #}
my $cmd = "("; my $cmd = "(";
$cmd .= "cd $snapdir;find . $findargs|sed 's/\\\\/\\\\\\\\/g'|";
$cmd .= "tar c${zflag}pf - $taropts --null -T -";
if ($opts->{bwlimit}) { $cmd .= "cd $snapdir;find . $findargs|sed 's/\\\\/\\\\\\\\/g'|";
my $bwl = $opts->{bwlimit}*1024; # bandwidth limit for cstream $cmd .= "tar cpf - $taropts --null -T -";
$cmd .= "|cstream -t $bwl"; my $bwl = $opts->{bwlimit}*1024; # bandwidth limit for cstream
} $cmd .= "|cstream -t $bwl" if $opts->{bwlimit};
$cmd .= "|$comp" if $comp;
$cmd .= ")"; $cmd .= ")";

2
PVE/VZDump/Plugin.pm
View File

@ -116,7 +116,7 @@ sub assemble {
} }
sub archive { sub archive {
my ($self, $task, $vmid, $filename) = @_; my ($self, $task, $vmid, $filename, $comp) = @_;
die "internal error"; # implement in subclass die "internal error"; # implement in subclass
} }

2
debian/control.in vendored
View File

@ -3,7 +3,7 @@ Version: @VERSION@-@PACKAGERELEASE@
Section: admin Section: admin
Priority: optional Priority: optional
Architecture: all Architecture: all
Depends: perl5, libtimedate-perl, apache2-mpm-prefork, libauthen-pam-perl, libintl-perl, rsync, libapache2-request-perl, libjson-perl, libdigest-sha1-perl, liblockfile-simple-perl, vncterm, qemu-server (>= 1.1-1), libwww-perl, wget, libnet-dns-perl, vlan, ifenslave-2.6 (>= 1.1.0-10), liblinux-inotify2-perl, debconf (>= 0.5) | debconf-2.0, netcat-traditional, pve-cluster, libpve-common-perl, libpve-storage-perl, libterm-readline-gnu-perl, libpve-access-control, libio-socket-ssl-perl, libfilesys-df-perl, libfile-readbackwards-perl, libfile-sync-perl, redhat-cluster-pve, resource-agents-pve, fence-agents-pve, cstream, mail-transport-agent, libxml-parser-perl, perl-suid Depends: perl5, libtimedate-perl, apache2-mpm-prefork, libauthen-pam-perl, libintl-perl, rsync, libapache2-request-perl, libjson-perl, libdigest-sha1-perl, liblockfile-simple-perl, vncterm, qemu-server (>= 1.1-1), libwww-perl, wget, libnet-dns-perl, vlan, ifenslave-2.6 (>= 1.1.0-10), liblinux-inotify2-perl, debconf (>= 0.5) | debconf-2.0, netcat-traditional, pve-cluster, libpve-common-perl, libpve-storage-perl, libterm-readline-gnu-perl, libpve-access-control, libio-socket-ssl-perl, libfilesys-df-perl, libfile-readbackwards-perl, libfile-sync-perl, redhat-cluster-pve, resource-agents-pve, fence-agents-pve, cstream, mail-transport-agent, libxml-parser-perl, perl-suid, lzop
Conflicts: netcat-openbsd, vzdump Conflicts: netcat-openbsd, vzdump
Replaces: vzdump Replaces: vzdump
Provides: vzdump Provides: vzdump