ui: ha/Resources: eslint fixes and code cleanup/refactoring/modernize

Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>

www/manager6/ha/Resources.js

@@ -8,17 +8,14 @@ Ext.define('PVE.ha.ResourcesView', {
     stateId: 'grid-ha-resources',
 
     initComponent: function() {
-	var me = this;
+	let me = this;
-
-	var caps = Ext.state.Manager.get('GuiCap');
 
 	if (!me.rstore) {
 	    throw "no store given";
 	}
 
 	Proxmox.Utils.monStoreErrors(me, me.rstore);
-
+	let store = Ext.create('Proxmox.data.DiffStore', {
-	var store = Ext.create('Proxmox.data.DiffStore', {
 	    rstore: me.rstore,
 	    filters: {
 		property: 'type',
@@ -26,65 +23,29 @@ Ext.define('PVE.ha.ResourcesView', {
 	    },
 	});
 
-	var reload = function() {
+	let sm = Ext.create('Ext.selection.RowModel', {});
-	    me.rstore.load();
-	};
 
-	var render_error = function(dataIndex, value, metaData, record) {
+	let run_editor = function() {
-	    var errors = record.data.errors;
+	    let rec = sm.getSelection()[0];
-	    if (errors) {
+	    let sid = rec.data.sid;
-		var msg = errors[dataIndex];
-		if (msg) {
-		    metaData.tdCls = 'proxmox-invalid-row';
-		    var html = '<p>' + Ext.htmlEncode(msg) + '</p>';
-		    metaData.tdAttr = 'data-qwidth=600 data-qtitle="ERROR" data-qtip="' +
-			html.replace(/\"/g, '&quot;') + '"';
-		}
-	    }
-	    return value;
-	};
 
-	var sm = Ext.create('Ext.selection.RowModel', {});
+	    let res = sid.match(/^(\S+):(\S+)$/);
-
+	    if (!res || (res[1] !== 'vm' && res[1] !== 'ct')) {
-	var run_editor = function() {
+		console.warn(`unknown HA service ID type ${sid}`);
-	    var rec = sm.getSelection()[0];
-	    var sid = rec.data.sid;
-
-	    var regex = /^(\S+):(\S+)$/;
-	    var res = regex.exec(sid);
-
-	    if (res[1] !== 'vm' && res[1] !== 'ct') {
 		return;
 	    }
-	    var guestType = res[1];
+	    let [, guestType, vmid] = res;
-	    var vmid = res[2];
+	    Ext.create('PVE.ha.VMResourceEdit', {
-
-            var win = Ext.create('PVE.ha.VMResourceEdit', {
 		guestType: guestType,
 		vmid: vmid,
+		listeners: {
+		    destroy: () => me.rstore.load(),
+		},
+		autoShow: true,
             });
-            win.on('destroy', reload);
-            win.show();
 	};
 
-	var remove_btn = Ext.create('Proxmox.button.StdRemoveButton', {
+	let caps = Ext.state.Manager.get('GuiCap');
-	    selModel: sm,
-	    baseurl: '/cluster/ha/resources/',
-	    getUrl: function(rec) {
-		var me = this;
-		return me.baseurl + '/' + rec.get('sid');
-	    },
-	    callback: function() {
-		reload();
-	    },
-	});
-
-	var edit_btn = new Proxmox.button.Button({
-	    text: gettext('Edit'),
-	    disabled: true,
-	    selModel: sm,
-	    handler: run_editor,
-	});
 
 	Ext.apply(me, {
 	    store: store,
@@ -97,14 +58,29 @@ Ext.define('PVE.ha.ResourcesView', {
 		    text: gettext('Add'),
 		    disabled: !caps.nodes['Sys.Console'],
 		    handler: function() {
-			var win = Ext.create('PVE.ha.VMResourceEdit', {});
+			Ext.create('PVE.ha.VMResourceEdit', {
-			win.on('destroy', reload);
+			    listeners: {
-			win.show();
+				destroy: () => me.rstore.load(),
+			    },
+			    autoShow: true,
+			});
 		    },
 		},
-		edit_btn, remove_btn,
+		{
+		    text: gettext('Edit'),
+		    disabled: true,
+		    selModel: sm,
+		    handler: run_editor,
+		},
+		{
+		    xtype: 'proxmoxStdRemoveButton',
+		    selModel: sm,
+		    getUrl: function(rec) {
+			return `/cluster/ha/resources/${rec.get('sid')}`;
+		    },
+		    callback: () => me.rstore.load(),
+		},
 	    ],
-
 	    columns: [
 		{
 		    header: 'ID',
@@ -129,9 +105,7 @@ Ext.define('PVE.ha.ResourcesView', {
 		    width: 100,
 		    hidden: true,
 		    sortable: true,
-		    renderer: function(v) {
+		    renderer: v => v || 'started',
-			return v || 'started';
-		    },
 		    dataIndex: 'request_state',
 		},
 		{
@@ -165,8 +139,13 @@ Ext.define('PVE.ha.ResourcesView', {
 		    header: gettext('Group'),
 		    width: 200,
 		    sortable: true,
-		    renderer: function(value, metaData, record) {
+		    renderer: function(value, metaData, { data }) {
-			return render_error('group', value, metaData, record);
+			if (data.errors && data.errors.group) {
+			    metaData.tdCls = 'proxmox-invalid-row';
+			    let html = `<p>${Ext.htmlEncode(data.errors.group)}</p>`;
+			    metaData.tdAttr = 'data-qwidth=600 data-qtitle="ERROR" data-qtip="' + html + '"';
+			}
+			return value;
 		    },
 		    dataIndex: 'group',
 		},
@@ -178,11 +157,7 @@ Ext.define('PVE.ha.ResourcesView', {
 		},
 	    ],
 	    listeners: {
-		beforeselect: function(grid, record, index, eOpts) {
+		beforeselect: (grid, record, index, eOpts) => caps.nodes['Sys.Console'],
-		    if (!caps.nodes['Sys.Console']) {
-			return false;
-		    }
-		},
 		itemdblclick: run_editor,
 	    },
 	});