proxmox-mirrors/pve-manager
1
0
Fork 0
mirror of https://git.proxmox.com/git/pve-manager synced 2025-08-11 14:54:41 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

fix permissions on node API

Browse Source 
Remove upload method (now in PVE::API2::Storage::Status)
This commit is contained in:
Dietmar Maurer 2012-02-06 09:54:09 +01:00
parent 461e4a46d1
commit d0289a19e5
1 changed files with 10 additions and 74 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

84
PVE/API2/Nodes.pm
View File

@ -104,7 +104,6 @@ __PACKAGE__->register_method ({
{ name => 'services' },
{ name => 'scan' },
{ name => 'storage' },
{ name => 'upload' },
{ name => 'qemu' },
{ name => 'openvz' },
{ name => 'vzdump' },
@ -488,6 +487,7 @@ __PACKAGE__->register_method ({
method => 'POST',
protected => 1,
permissions => {
description => "Restricted to users on realm 'pam'",
check => ['perm', '/nodes/{node}', [ 'Sys.Console' ]],
},
description => "Creates a VNC Shell proxy.",
@ -512,7 +512,9 @@ __PACKAGE__->register_method ({
my $rpcenv = PVE::RPCEnvironment::get();
my $user = $rpcenv->get_user();
my ($user, undef, $realm) = verify_username($rpcenv->get_user());
raise_perm_exc("realm != pam") if $realm ne 'pam';
my $node = $param->{node};
@ -626,6 +628,9 @@ __PACKAGE__->register_method({
path => 'dns',
method => 'PUT',
description => "Write DNS settings.",
permissions => {
check => ['perm', '/nodes/{node}', [ 'Sys.Modify' ]],
},
proxyto => 'node',
protected => 1,
parameters => {
@ -716,6 +721,9 @@ __PACKAGE__->register_method({
path => 'time',
method => 'PUT',
description => "Set time zone.",
permissions => {
check => ['perm', '/nodes/{node}', [ 'Sys.Modify' ]],
},
proxyto => 'node',
protected => 1,
parameters => {
@ -737,78 +745,6 @@ __PACKAGE__->register_method({
return undef;
}});
__PACKAGE__->register_method ({
name => 'upload',
path => 'upload',
method => 'POST',
permissions => {
check => ['perm', '/storage/{storage}', [ 'Datastore.AllocateSpace' ]],
},
description => "Upload content.",
parameters => {
additionalProperties => 0,
properties => {
node => get_standard_option('pve-node'),
storage => get_standard_option('pve-storage-id'),
filename => {
description => "The name of the file to create/upload.",
type => 'string',
},
vmid => get_standard_option
('pve-vmid', {
description => "Specify owner VM",
optional => 1,
}),
},
},
returns => {
description => "Volume identifier",
type => 'string',
},
code => sub {
my ($param) = @_;
# todo: can we proxy file uploads to remote nodes?
if ($param->{node} ne PVE::INotify::nodename()) {
raise_param_exc({ node => "can't upload content to remote node" });
}
my $node = $param->{node};
my $storeid = $param->{storage};
my $name = $param->{filename};
my $fh = CGI::upload('filename') || die "unable to get file handle\n";
syslog ('info', "UPLOAD $name to $node $storeid");
# fixme:
die "upload not implemented\n";
my $buffer = "";
my $tmpname = "/tmp/proxmox_upload-$$.bin";
eval {
open FILE, ">$tmpname" || die "can't open temporary file '$tmpname' - $!\n";
while (read($fh, $buffer, 32768)) {
die "write failed - $!" unless print FILE $buffer;
}
close FILE || die " can't close temporary file '$tmpname' - $!\n";
};
my $err = $@;
if ($err) {
unlink $tmpname;
die $err;
}
unlink $tmpname; # fixme: proxy to local host import
# fixme: return volid
return undef;
}});
package PVE::API2::Nodes;
use strict;