proxmox-mirrors/pve-manager
1
0
Fork 0
mirror of https://git.proxmox.com/git/pve-manager synced 2025-08-06 07:20:36 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

fix #2745: ui: backup: allow specifying remove parameter for manual backup

Browse Source 
and also show the retention options that will be used for a given storage. A
user with Datastore.AllocateSpace and VM.Backup can already remove backups from
the GUI manually, so it shouldn't be a problem if they can set the remove flag
when starting a manual backup in the GUI.

Signed-off-by: Fabian Ebner <f.ebner@proxmox.com>
This commit is contained in:
Fabian Ebner 2021-04-06 12:41:52 +02:00 committed by Thomas Lamprecht
parent fddb041217
commit cfc6d15ed0
1 changed files with 65 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

67
www/manager6/window/Backup.js
View File

@ -36,6 +36,39 @@ Ext.define('PVE.window.Backup', {
emptyText: Proxmox.Utils.noneText,
});
const keepNames = [
'keep-last',
'keep-hourly',
'keep-daily',
'keep-weekly',
'keep-monthly',
'keep-yearly',
];
let pruneSettings = keepNames.map(
name => Ext.create('Ext.form.field.Display', {
name: name,
fieldLabel: gettext(name),
hidden: true,
disabled: true,
}),
);
let removeCheckbox = Ext.create('Proxmox.form.Checkbox', {
name: 'remove',
checked: false,
hidden: true,
uncheckedValue: 0,
fieldLabel: gettext('Prune'),
autoEl: {
tag: 'div',
'data-qtip': gettext('Prune older backups afterwards'),
},
handler: function(checkbox, value) {
pruneSettings.forEach(field => field.setDisabled(!value));
},
});
let initialDefaults = false;
var storagesel = Ext.create('PVE.form.StorageSelector', {
@ -74,6 +107,35 @@ Ext.define('PVE.window.Backup', {
}
initialDefaults = true;
// always update storage dependent properties
if (data['prune-backups'] !== undefined) {
const keepParams = PVE.Parser.parsePropertyString(
data["prune-backups"],
);
if (!keepParams['keep-all']) {
removeCheckbox.setHidden(false);
pruneSettings.forEach(function(field) {
const keep = keepParams[field.name];
if (keep) {
field.setValue(keep);
field.setHidden(false);
} else {
field.reset();
field.setHidden(true);
}
});
return;
}
}
// no defaults or keep-all=1
removeCheckbox.setHidden(true);
removeCheckbox.setValue(false);
pruneSettings.forEach(function(field) {
field.reset();
field.setHidden(true);
});
},
failure: function(response, opts) {
Ext.Msg.alert(gettext('Error'), response.htmlStatus);
@ -96,7 +158,8 @@ Ext.define('PVE.window.Backup', {
modeSelector,
compressionSelector,
mailtoField,
],
removeCheckbox,
].concat(pruneSettings),
});
var form = me.formPanel.getForm();
@ -110,7 +173,7 @@ Ext.define('PVE.window.Backup', {
storage: storage,
vmid: me.vmid,
mode: values.mode,
remove: 0,
remove: values.remove,
};
if (values.mailto) {