From b48c66655c6ff032a0d5b93550f1240b47adb923 Mon Sep 17 00:00:00 2001 From: Thomas Lamprecht Date: Tue, 16 Nov 2021 14:17:42 +0100 Subject: [PATCH] ui: qemu: disk edit: drop label widths from advanced columns this is a historical left over from the time when the bandwidth limits weren't in their own, separate tab, as there we got quite long labels and we synced the width up for the remaining fields to avoid that it looks to much off. Luckily not required anymore, so just drop it for non BW fields. Signed-off-by: Thomas Lamprecht --- www/manager6/qemu/HDEdit.js | 10 ++-------- 1 file changed, 2 insertions(+), 8 deletions(-) diff --git a/www/manager6/qemu/HDEdit.js b/www/manager6/qemu/HDEdit.js index 7e470e39..c643ee73 100644 --- a/www/manager6/qemu/HDEdit.js +++ b/www/manager6/qemu/HDEdit.js @@ -177,8 +177,6 @@ Ext.define('PVE.qemu.HDInputPanel', { initComponent: function() { var me = this; - var labelWidth = 140; - me.drive = {}; let column1 = []; @@ -259,7 +257,6 @@ Ext.define('PVE.qemu.HDInputPanel', { { xtype: 'proxmoxcheckbox', fieldLabel: gettext('SSD emulation'), - labelWidth: labelWidth, name: 'ssd', clearOnDisable: true, bind: { @@ -270,7 +267,6 @@ Ext.define('PVE.qemu.HDInputPanel', { xtype: 'proxmoxcheckbox', name: 'iothread', fieldLabel: 'IO thread', - labelWidth: labelWidth, clearOnDisable: true, bind: { disabled: '{!isVirtIO && !isSCSI}', @@ -281,7 +277,6 @@ Ext.define('PVE.qemu.HDInputPanel', { name: 'readOnly', // `ro` in the config, we map in get/set values defaultValue: 0, fieldLabel: gettext('Read-only'), - labelWidth: labelWidth, clearOnDisable: true, bind: { disabled: '{!isVirtIO && !isSCSI}', @@ -297,7 +292,6 @@ Ext.define('PVE.qemu.HDInputPanel', { tag: 'div', 'data-qtip': gettext('Include volume in backup job'), }, - labelWidth: labelWidth, name: 'backup', bind: { value: '{isIncludedInBackup}', @@ -306,7 +300,6 @@ Ext.define('PVE.qemu.HDInputPanel', { { xtype: 'proxmoxcheckbox', fieldLabel: gettext('Skip replication'), - labelWidth: labelWidth, name: 'noreplicate', }, { @@ -315,7 +308,6 @@ Ext.define('PVE.qemu.HDInputPanel', { fieldLabel: gettext('Async IO'), allowBlank: false, value: '__default__', - labelWidth: labelWidth, comboItems: [ ['__default__', Proxmox.Utils.defaultText + ' (io_uring)'], ['io_uring', 'io_uring'], @@ -325,6 +317,8 @@ Ext.define('PVE.qemu.HDInputPanel', { }, ); + let labelWidth = 140; + let bwColumn1 = [ { xtype: 'numberfield',