From ae58eee8581237435aec8c82ad6de5b06705ed9f Mon Sep 17 00:00:00 2001 From: Dietmar Maurer Date: Thu, 29 Aug 2013 08:57:18 +0200 Subject: [PATCH] do not use gettext() inside render functions For performance reasons. --- www/manager/node/StatusView.js | 12 +++++++++--- 1 file changed, 9 insertions(+), 3 deletions(-) diff --git a/www/manager/node/StatusView.js b/www/manager/node/StatusView.js index 43f7a7ac..730ecb7d 100644 --- a/www/manager/node/StatusView.js +++ b/www/manager/node/StatusView.js @@ -10,10 +10,13 @@ Ext.define('PVE.node.StatusView', { throw "no node name specified"; } + var socketText = gettext('Socket'); + var socketsText = gettext('Sockets'); + var render_cpuinfo = function(value) { return value.cpus + " x " + value.model + " (" + value.sockets.toString() + " " + - (value.sockets > 1 ? gettext('Sockets') : gettext('Socket')) + ")"; + (value.sockets > 1 ? socketsText : socketText) + ")"; }; var render_loadavg = function(value) { @@ -29,10 +32,13 @@ Ext.define('PVE.node.StatusView', { return PVE.Utils.format_size(value.shared); }; + var totalText = gettext('Total'); + var usedText = gettext('Used'); + var render_meminfo = function(value) { var per = (value.used / value.total)*100; - var text = "
" + gettext('Total') + ": " + PVE.Utils.format_size(value.total) + "
" + - "
" + gettext('Used') + ": " + PVE.Utils.format_size(value.used) + "
"; + var text = "
" + totalText + ": " + PVE.Utils.format_size(value.total) + "
" + + "
" + usedText + ": " + PVE.Utils.format_size(value.used) + "
"; return text; };