From 9a023d5540b909a39af2743c6e1ffadb73ae98d6 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Fabian=20Gr=C3=BCnbichler?= Date: Mon, 17 Apr 2023 09:04:18 +0200 Subject: [PATCH] fix #4605: drop rsyncable from zstd invocation MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit This reverts 7420d7ff ("zstd: add --rsyncable flag") That flag causes severe slow downs on fast disks, and we still have other rsyncable compressors available. It was originally added based on wrong documentation that made the performance impact look a lot smaller than it actually is. Signed-off-by: Fabian Grünbichler --- PVE/VZDump.pm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/PVE/VZDump.pm b/PVE/VZDump.pm index df6fd64b..64a5fd4f 100644 --- a/PVE/VZDump.pm +++ b/PVE/VZDump.pm @@ -767,7 +767,7 @@ sub compressor_info { my $cpuinfo = PVE::ProcFSTools::read_cpuinfo(); $zstd_threads = int(($cpuinfo->{cpus} + 1)/2); } - return ("zstd --rsyncable --threads=${zstd_threads}", 'zst'); + return ("zstd --threads=${zstd_threads}", 'zst'); } else { die "internal error - unknown compression option '$opt_compress'"; }