proxmox-mirrors/pve-manager
1
0
Fork 0
mirror of https://git.proxmox.com/git/pve-manager synced 2025-08-11 20:17:19 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

aplinfo: use explicit defined checks

Browse Source 
a checksum of '0' can never be correct, but this makes the code clearer
This commit is contained in:
Fabian Grünbichler 2016-08-24 12:27:42 +02:00 committed by Dietmar Maurer
parent 79be6db38a
commit 95f99e8c5e
1 changed files with 4 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
PVE/API2/Nodes.pm
View File

@ -1116,10 +1116,12 @@ __PACKAGE__->register_method({
eval { eval {
open(my $fh, '<', $filename) or die "Can't open '$filename': $!"; open(my $fh, '<', $filename) or die "Can't open '$filename': $!";
binmode($fh); binmode($fh);
if ($expected = $template_info->{sha512sum}) { if (defined($template_info->{sha512sum})) {
$expected = $template_info->{sha512sum};
$digest = Digest::SHA->new(512)->addfile($fh)->hexdigest; $digest = Digest::SHA->new(512)->addfile($fh)->hexdigest;
} elsif ($expected = $template_info->{md5sum}) { } elsif (defined($template_info->{md5sum})) {
#fallback to MD5 #fallback to MD5
$expected = $template_info->{md5sum};
$digest = Digest::MD5->new->addfile($fh)->hexdigest; $digest = Digest::MD5->new->addfile($fh)->hexdigest;
} else { } else {
die "no expected checksum defined"; die "no expected checksum defined";