proxmox-mirrors/pve-manager
1
0
Fork 0
mirror of https://git.proxmox.com/git/pve-manager synced 2025-10-04 07:48:57 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

ui: backup: move change detection help tooltip behind field

Browse Source 
instead of having it in a separate line. This could be confusing on
first glance, e.g. if it belongs to the line above or below.

To make it more clear, put it in line with the field itself.

Because this uses a FieldContainer now, we can use that to hide and show
both at the same time, reducing the amount of code a bit.

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
This commit is contained in:
Dominik Csapak 2025-04-10 16:18:03 +02:00 committed by Thomas Lamprecht
parent 129777f3d5
commit 8a14d5d91b
1 changed files with 24 additions and 17 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

41
www/manager6/window/Backup.js
View File

@ -53,18 +53,10 @@ Ext.define('PVE.window.Backup', {
},
});
let pbsChangeDetectionHelp = Ext.create('Ext.Component', {
hidden: true,
html: `<i class="fa fa-question-circle" data-qtip="
${gettext("Mode to detect file changes and switch archive encoding format for container backups to Proxmox Backup Server. Not available for VM backups.")}
"></i>`,
});
let pbsChangeDetectionModeSelector = Ext.create({
xtype: 'proxmoxKVComboBox',
hidden: true,
flex: 1,
disabled: true,
fieldLabel: gettext('PBS change detection mode'),
name: 'pbs-change-detection-mode',
deleteEmpty: true,
value: '__default__',
@ -75,6 +67,25 @@ Ext.define('PVE.window.Backup', {
],
});
let pbsChangeDetection = Ext.create('Ext.form.FieldContainer', {
fieldLabel: gettext('PBS change detection mode'),
hidden: true,
layout: {
type: 'hbox',
align: 'center',
},
items: [
pbsChangeDetectionModeSelector,
{
xtype: 'box',
html: `<i class="fa fa-question-circle" data-qtip="
${gettext("Mode to detect file changes and switch archive encoding format for container backups to Proxmox Backup Server. Not available for VM backups.")}
"></i>`,
padding: 5,
},
],
});
const keepNames = [
['keep-last', gettext('Keep Last')],
['keep-hourly', gettext('Keep Hourly')],
@ -135,20 +146,17 @@ Ext.define('PVE.window.Backup', {
if (me.vmtype === 'lxc') {
pbsChangeDetectionModeSelector.setValue('__default__');
pbsChangeDetectionModeSelector.setDisabled(false);
pbsChangeDetectionModeSelector.setHidden(false);
pbsChangeDetectionHelp.setHidden(false);
pbsChangeDetection.setHidden(false);
} else {
pbsChangeDetectionModeSelector.setDisabled(true);
pbsChangeDetectionModeSelector.setHidden(true);
pbsChangeDetectionHelp.setHidden(true);
pbsChangeDetection.setHidden(true);
}
} else {
if (!compressionSelector.getEditable()) {
compressionSelector.setDisabled(false);
}
pbsChangeDetectionModeSelector.setDisabled(true);
pbsChangeDetectionModeSelector.setHidden(true);
pbsChangeDetectionHelp.setHidden(true);
pbsChangeDetection.setHidden(true);
}
@ -231,8 +239,7 @@ Ext.define('PVE.window.Backup', {
storagesel,
modeSelector,
protectedCheckbox,
pbsChangeDetectionHelp,
pbsChangeDetectionModeSelector,
pbsChangeDetection,
],
column2: [
compressionSelector,