From 82a33d4ef7fa2011e468aee6a4d266ee23e5927c Mon Sep 17 00:00:00 2001 From: Thomas Lamprecht Date: Mon, 10 Jun 2019 19:04:10 +0200 Subject: [PATCH] gui: tree: add lock information to tooltips This was already proposed by Dominik[0], but it was was wished for a faster backend backing of this[1], and as with most wishes one needs to either be content with what's there or (try) to improve it one self.. So with the IPCC approach proposed as backing for this I'd like to add this again. It differs from [0] a bit, first it's rebased as parts of the tooltip stuff got already applied[2]. I use "Config locked ()" as text for this, as it 1. Clarifies what the lock symbol means, which is always a good thing for tooltips 2. repeating the lock symbol here again would show the users three lock symbols at the same time if the VM was selected in the tree (the tree one, the VM config panel one, and this tool tip one) this is a bit much, so don't do it. [0]: https://pve.proxmox.com/pipermail/pve-devel/2019-February/035829.html [1]: https://pve.proxmox.com/pipermail/pve-devel/2019-March/035930.html [2]: https://pve.proxmox.com/pipermail/pve-devel/2019-March/036165.html Co-developed-by: Dominik Csapak Signed-off-by: Thomas Lamprecht --- www/manager6/tree/ResourceTree.js | 3 +++ 1 file changed, 3 insertions(+) diff --git a/www/manager6/tree/ResourceTree.js b/www/manager6/tree/ResourceTree.js index 360e7e73..fe74978e 100644 --- a/www/manager6/tree/ResourceTree.js +++ b/www/manager6/tree/ResourceTree.js @@ -137,6 +137,9 @@ Ext.define('PVE.tree.ResourceTree', { } var qtips = [gettext('Status') + ': ' + (info.qmpstatus || info.status)]; + if (info.lock) { + qtips.push('Config locked (' + info.lock + ')'); + } if (info.hastate != 'unmanaged') { qtips.push(gettext('HA State') + ": " + info.hastate); }