From 6ac64c3aed53609f2b74e985c7f34c2a3a088344 Mon Sep 17 00:00:00 2001 From: Thomas Lamprecht Date: Wed, 6 May 2020 19:11:12 +0200 Subject: [PATCH] fix undefined access on acme variable We have 4 call sites of that, one had a fallback - the other three was totally unchecked and triggered already exceptions on panel render ... -.- Signed-off-by: Thomas Lamprecht --- www/manager6/Parser.js | 2 +- www/manager6/node/ACME.js | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/www/manager6/Parser.js b/www/manager6/Parser.js index 20d81d4a..9fa71cf0 100644 --- a/www/manager6/Parser.js +++ b/www/manager6/Parser.js @@ -14,7 +14,7 @@ Ext.define('PVE.Parser', { statics: { parseACME: function(value) { if (!value) { - return; + return {}; } var res = {}; diff --git a/www/manager6/node/ACME.js b/www/manager6/node/ACME.js index 33159b2e..fbc9086d 100644 --- a/www/manager6/node/ACME.js +++ b/www/manager6/node/ACME.js @@ -205,7 +205,7 @@ Ext.define('PVE.node.ACMEDomainEdit', { }; let configkey = olddomain.configkey; - let acmeObj = PVE.Parser.parseACME(nodeconfig.acme) || {}; + let acmeObj = PVE.Parser.parseACME(nodeconfig.acme); if (values.type === 'dns') { if (!olddomain.configkey || olddomain.configkey === 'acme') {