proxmox-mirrors/pve-manager
1
0
Fork 0
mirror of https://git.proxmox.com/git/pve-manager synced 2025-08-13 23:06:47 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

ceph: pool set: improve handling "size" parameter

Browse Source 
instead of fully duplicating the code just order it first if it
exists...

Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
This commit is contained in:
Thomas Lamprecht 2021-04-21 15:49:38 +02:00
parent 84b08e8aec
commit 69c0ff3e60
1 changed files with 4 additions and 12 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

16
PVE/Ceph/Tools.pm
View File

@ -228,21 +228,13 @@ my $set_pool_setting = sub {
sub set_pool {
my ($pool, $param) = @_;
# by default, pool size always sets min_size,
# set it and forget it, as first item
# by default, pool size always resets min_size, so set it as first item
# https://tracker.ceph.com/issues/44862
if ($param->{size}) {
my $value = $param->{size};
if (my $err = $set_pool_setting->($pool, 'size', $value)) {
print "$err";
} else {
delete $param->{size};
}
}
my $keys = [ grep { $_ ne 'size' } sort keys %$param ];
unshift @$keys, 'size' if exists $param->{size};
foreach my $setting (keys %$param) {
for my $setting (@$keys) {
my $value = $param->{$setting};
next if $setting eq 'size';
if (my $err = $set_pool_setting->($pool, $setting, $value)) {
print "$err";