From 5ab9a243835d24e56d6142a0d81b8a028fc88d77 Mon Sep 17 00:00:00 2001
From: Thomas Lamprecht <t.lamprecht@proxmox.com>
Date: Fri, 28 Jun 2019 19:46:44 +0200
Subject: [PATCH] api2tools: refactor get_resource_pool_guest_members and
 declare missing use

Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
---
 PVE/API2Tools.pm | 13 ++++---------
 1 file changed, 4 insertions(+), 9 deletions(-)

diff --git a/PVE/API2Tools.pm b/PVE/API2Tools.pm
index e79ac9b2..2d1dd292 100644
--- a/PVE/API2Tools.pm
+++ b/PVE/API2Tools.pm
@@ -8,6 +8,7 @@ use PVE::Exception qw(raise_param_exc);
 use PVE::Tools;
 use PVE::INotify;
 use PVE::Cluster;
+use PVE::RPCEnvironment;
 use Digest::MD5 qw(md5_hex);
 use URI;
 use URI::Escape;
@@ -241,17 +242,11 @@ sub get_resource_pool_guest_members {
 
     my $data = $usercfg->{pools}->{$pool};
 
-    die "pool '$pool' does not exist\n"
-	if !$data;
+    die "pool '$pool' does not exist\n" if !$data;
 
-    my $members = [];
+    my $pool_members = [ grep { $idlist->{$_} } keys %{$data->{vms}} ];
 
-    foreach my $vmid (keys %{$data->{vms}}) {
-	my $vmdata = $idlist->{$vmid};
-	next if !$vmdata;
-	push @$members, $vmid;
-    }
-    return $members;
+    return $pool_members;
 }
 
 1;