From 4d7acd65bf87ade3231bab9c4359a1fb810b3ba3 Mon Sep 17 00:00:00 2001 From: Thomas Lamprecht Date: Wed, 21 Apr 2021 13:27:30 +0200 Subject: [PATCH] ceph: pool edit: improve UX of target size/ratio fields s/Target Size Ratio/Target Ratio/, shorter and ceph docs call it also that way, allows do drop the non-standard label width. Add tooltips to explain both, target size and ratio, a bit. Signed-off-by: Thomas Lamprecht --- www/manager6/ceph/Pool.js | 17 +++++++++++------ 1 file changed, 11 insertions(+), 6 deletions(-) diff --git a/www/manager6/ceph/Pool.js b/www/manager6/ceph/Pool.js index 9cd79177..693b3e04 100644 --- a/www/manager6/ceph/Pool.js +++ b/www/manager6/ceph/Pool.js @@ -121,34 +121,39 @@ Ext.define('PVE.CephPoolInputPanel', { advancedColumn2: [ { xtype: 'numberfield', - fieldLabel: gettext('Target Size Ratio'), + fieldLabel: gettext('Target Ratio'), name: 'target_size_ratio', - labelWidth: 140, minValue: 0, decimalPrecision: 3, allowBlank: true, emptyText: '0.0', + autoEl: { + tag: 'div', + 'data-qtip': gettext('The ratio of storage amount this pool will consume compared to other pools with ratios. Used for auto-scaling.'), + }, }, { xtype: 'pveSizeField', - fieldLabel: gettext('Target Size') + ' (GiB)', name: 'target_size', - labelWidth: 140, + fieldLabel: gettext('Target Size'), unit: 'GiB', minValue: 0, allowBlank: true, emptyText: '0', + autoEl: { + tag: 'div', + 'data-qtip': gettext('The amount of data eventually stored in this pool. Used for auto-scaling.'), + }, }, { xtype: 'displayfield', userCls: 'pmx-hint', - value: 'Target Size Ratio takes precedence.', + value: Ext.String.format(gettext('{0} takes precedence.'), gettext('Target Ratio')), // FIXME: tooltip? }, { xtype: 'proxmoxintegerfield', fieldLabel: 'Min. # of PGs', name: 'pg_num_min', - labelWidth: 140, minValue: 0, allowBlank: true, emptyText: '0',