proxmox-mirrors/pve-manager
1
0
Fork 0
mirror of https://git.proxmox.com/git/pve-manager synced 2025-07-26 08:42:18 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

pve6to7: improve vzdump.cron check

Browse Source 
handle errors, and fix filename referenced in the warning.

Signed-off-by: Fabian Grünbichler <f.gruenbichler@proxmox.com>
This commit is contained in:
Fabian Grünbichler 2021-06-16 13:26:38 +02:00
parent e522a2db5c
commit 437ade60b5
1 changed files with 10 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
PVE/CLI/pve6to7.pm
View File

@ -563,12 +563,18 @@ sub check_backup_retention_settings {
"7.x will no longer keep only the last backup, but all backups"); "7.x will no longer keep only the last backup, but all backups");
} }
eval {
my $vzdump_cron = PVE::Cluster::cfs_read_file('vzdump.cron'); my $vzdump_cron = PVE::Cluster::cfs_read_file('vzdump.cron');
# only warn once, there might be many jobs... # only warn once, there might be many jobs...
if (scalar(grep { defined($_->{maxfiles}) } $vzdump_cron->{jobs}->@*)) { if (scalar(grep { defined($_->{maxfiles}) } $vzdump_cron->{jobs}->@*)) {
$pass = 0; $pass = 0;
log_warn("/etc/pve/vzdump_cron - $maxfiles_msg"); log_warn("/etc/pve/vzdump.cron - $maxfiles_msg");
}
};
if (my $err = $@) {
$pass = 0;
log_warn("unable to parse node's VZDump configuration - $err");
} }
log_pass("no problems found.") if $pass; log_pass("no problems found.") if $pass;