proxmox-mirrors/pve-manager
1
0
Fork 0
mirror of https://git.proxmox.com/git/pve-manager synced 2025-08-16 13:01:29 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

fix wizard validity check for options spanning multiple tabs

Browse Source 
when changing the guest os, we changed the disk type
(e.g. ide for windows, scsi for linux, etc.)

but if the id was outside the allowed range (e.g. > 3 for ide)
we did not correctly enable/disable tabs

now we check all tabs until the highest already visited,
or until we detect a not valid tab

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
Reviewed-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
This commit is contained in:
Dominik Csapak 2018-02-15 16:05:51 +01:00 committed by Thomas Lamprecht
parent cb90483c5d
commit 373d7ea44e
1 changed files with 33 additions and 11 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

44
www/manager6/window/Wizard.js
View File

@ -53,6 +53,9 @@ Ext.define('PVE.window.Wizard', {
}); });
tabs[0].disabled = false; tabs[0].disabled = false;
var maxidx = 0;
var curidx = 0;
var check_card = function(card) { var check_card = function(card) {
var valid = true; var valid = true;
var fields = card.query('field, fieldcontainer'); var fields = card.query('field, fieldcontainer');
@ -97,7 +100,13 @@ Ext.define('PVE.window.Wizard', {
me.down('#submit').setDisabled(!valid); me.down('#submit').setDisabled(!valid);
me.down('#back').setDisabled(tp.items.indexOf(newcard) == 0); me.down('#back').setDisabled(tp.items.indexOf(newcard) == 0);
var next = tp.items.indexOf(newcard) + 1; var idx = tp.items.indexOf(newcard);
if (idx > maxidx) {
maxidx = idx;
}
curidx = idx;
var next = idx + 1;
var ntab = tp.items.getAt(next); var ntab = tp.items.getAt(next);
if (valid && ntab && !newcard.onSubmit) { if (valid && ntab && !newcard.onSubmit) {
ntab.enable(); ntab.enable();
@ -204,16 +213,29 @@ Ext.define('PVE.window.Wizard', {
Ext.Array.each(me.query('field'), function(field) { Ext.Array.each(me.query('field'), function(field) {
var validcheck = function() { var validcheck = function() {
var tp = me.down('#wizcontent'); var tp = me.down('#wizcontent');
var atab = tp.getActiveTab();
var valid = check_card(atab); // check tabs from current to the last enabled for validity
me.down('#next').setDisabled(!valid); // since we might have changed a validity on a later one
me.down('#submit').setDisabled(!valid); var i;
var next = tp.items.indexOf(atab) + 1; for (i = curidx; i <= maxidx && i < tp.items.getCount(); i++) {
var ntab = tp.items.getAt(next); var tab = tp.items.getAt(i);
if (!valid) { var valid = check_card(tab);
disable_at(ntab);
} else if (ntab && !atab.onSubmit) { // only set the buttons on the current panel
ntab.enable(); if (i === curidx) {
me.down('#next').setDisabled(!valid);
me.down('#submit').setDisabled(!valid);
}
// if a panel is invalid, then disable it and all following,
// else enable it and go to the next
var ntab = tp.items.getAt(i + 1);
if (!valid) {
disable_at(ntab);
return;
} else if (ntab && !tab.onSubmit) {
ntab.enable();
}
} }
}; };
field.on('change', validcheck); field.on('change', validcheck);