From 3571d98b5f6dba73c753f4ac70a66294a0c5ea86 Mon Sep 17 00:00:00 2001
From: Wolfgang Bumiller <w.bumiller@proxmox.com>
Date: Wed, 16 Aug 2023 11:58:20 +0200
Subject: [PATCH] fix mocking in notification tests

PVE::Notify::send_notification is now private (the mocking was for the
old api)

'cfs_read_file' gets exported into PVE::Notify before it gets mocked,
so it needs to be mocked inside PVE::Notify, not PVE::Cluster.

Signed-off-by: Wolfgang Bumiller <w.bumiller@proxmox.com>
---
 test/vzdump_notification_test.pl | 18 ++++++++++++++----
 1 file changed, 14 insertions(+), 4 deletions(-)

diff --git a/test/vzdump_notification_test.pl b/test/vzdump_notification_test.pl
index 0635ebb7..21c31651 100755
--- a/test/vzdump_notification_test.pl
+++ b/test/vzdump_notification_test.pl
@@ -37,15 +37,25 @@ my $result_text;
 my $result_properties;
 
 my $mock_notification_module = Test::MockModule->new('PVE::Notify');
-$mock_notification_module->mock('send_notification', sub {
+my $mocked_notify = sub {
     my ($channel, $severity, $title, $text, $properties) = @_;
 
     $result_text = $text;
     $result_properties = $properties;
-});
+};
+my $mocked_notify_short = sub {
+    my ($channel, @rest) = @_;
+    return $mocked_notify->($channel, '<some severity>', @rest);
+};
 
-my $mock_cluster_module = Test::MockModule->new('PVE::Cluster');
-$mock_cluster_module->mock('cfs_read_file', sub {
+$mock_notification_module->mock(
+    'notify' => $mocked_notify,
+    'info' => $mocked_notify_short,
+    'notice' => $mocked_notify_short,
+    'warning' => $mocked_notify_short,
+    'error' => $mocked_notify_short,
+);
+$mock_notification_module->mock('cfs_read_file', sub {
     my $path = shift;
 
     if ($path eq 'datacenter.cfg') {