appliance index: use upper case for constant like variables

Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
This commit is contained in:
Thomas Lamprecht 2024-02-28 14:28:09 +01:00
parent c6611893f6
commit 33b0c265ef

View File

@ -12,8 +12,8 @@ use PVE::Storage;
use PVE::Tools qw(run_command); use PVE::Tools qw(run_command);
use PVE::pvecfg; use PVE::pvecfg;
my $logfile = "/var/log/pveam.log"; my $LOGFILE = "/var/log/pveam.log";
my $aplinfodir = "/var/lib/pve-manager/apl-info"; my $APL_INFO_DIRECTORY = "/var/lib/pve-manager/apl-info";
sub logmsg { sub logmsg {
my ($logfd, $msg) = @_; my ($logfd, $msg) = @_;
@ -147,7 +147,7 @@ sub download_aplinfo {
my $aplsigurl = "$aplinfo->{url}/$aplinfo->{file}.asc"; my $aplsigurl = "$aplinfo->{url}/$aplinfo->{file}.asc";
my $host = $aplinfo->{host}; my $host = $aplinfo->{host};
my $tmp = "$aplinfodir/pveam-${host}.tmp.$$"; my $tmp = "$APL_INFO_DIRECTORY/pveam-${host}.tmp.$$";
my $tmpgz = "$tmp.gz"; my $tmpgz = "$tmp.gz";
my $sigfn = "$tmp.asc"; my $sigfn = "$tmp.asc";
@ -178,7 +178,7 @@ sub download_aplinfo {
eval { read_aplinfo($tmp, {}, $aplinfo->{url}, 1) }; eval { read_aplinfo($tmp, {}, $aplinfo->{url}, 1) };
die "update failed: $@" if $@; die "update failed: $@" if $@;
rename($tmp, "$aplinfodir/$host") or rename($tmp, "$APL_INFO_DIRECTORY/$host") or
die "update failed: unable to store data: $!\n"; die "update failed: unable to store data: $!\n";
logmsg($logfd, "update successful"); logmsg($logfd, "update successful");
@ -213,11 +213,11 @@ sub get_apl_sources {
sub update { sub update {
my ($proxy) = @_; my ($proxy) = @_;
my $logfile_size = -s $logfile || 0; my $logfile_size = -s $LOGFILE || 0;
if ($logfile_size > 1024 * 256) { if ($logfile_size > 1024 * 256) {
rename($logfile, "$logfile.0") or warn "failed to rotate log file $logfile - $!\n"; rename($LOGFILE, "$LOGFILE.0") or warn "failed to rotate log file $LOGFILE - $!\n";
} }
my $logfd = IO::File->new (">>$logfile"); my $logfd = IO::File->new (">>$LOGFILE");
logmsg($logfd, "starting update"); logmsg($logfd, "starting update");
my $ua = LWP::UserAgent->new; my $ua = LWP::UserAgent->new;
@ -232,7 +232,7 @@ sub update {
my $sources = get_apl_sources(); my $sources = get_apl_sources();
mkdir $aplinfodir; mkdir $APL_INFO_DIRECTORY;
my @dlerr = (); my @dlerr = ();
foreach my $info (@$sources) { foreach my $info (@$sources) {
@ -260,7 +260,7 @@ sub load_data {
foreach my $info (@$sources) { foreach my $info (@$sources) {
eval { eval {
my $host = $info->{host}; my $host = $info->{host};
read_aplinfo("$aplinfodir/$host", $list, $info->{url}); read_aplinfo("$APL_INFO_DIRECTORY/$host", $list, $info->{url});
}; };
warn $@ if $@; warn $@ if $@;
} }