proxmox-mirrors/pve-manager
1
0
Fork 0
mirror of https://git.proxmox.com/git/pve-manager synced 2025-08-14 15:58:20 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

fix #4521: api/tasks: replace upid as filename for task log downloads

Browse Source 
previously the upid would just be used without a file extension when
downloading a task log. this lead to rather strange filenames that
appeared unfamiliar to users as the upid is not very prevalent in the
gui. set a proper file name based on the node name, worker type and a
time stamp instead. also add the ".log" file extension to indicate
that these files contain logs.

Signed-off-by: Stefan Sterz <s.sterz@proxmox.com>
This commit is contained in:
Stefan Sterz 2023-02-09 12:43:14 +01:00 committed by Thomas Lamprecht
parent a219043af6
commit 31746f261a
1 changed files with 4 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
PVE/API2/Tasks.pm
View File

@ -405,13 +405,16 @@ __PACKAGE__->register_method({
open($fh, '<', $filename) or die "Could not open file '$filename' - $!\n"; open($fh, '<', $filename) or die "Could not open file '$filename' - $!\n";
} }
my $task_time = strftime('%FT%TZ', gmtime($task->{starttime}));
my $download_name = 'task-'.$task->{node}.'-'.$task->{type}.'-'.$task_time.'.log';
return { return {
download => { download => {
fh => $fh, fh => $fh,
stream => 1, stream => 1,
'content-encoding' => $use_compression ? 'gzip' : undef, 'content-encoding' => $use_compression ? 'gzip' : undef,
'content-type' => "text/plain", 'content-type' => "text/plain",
'content-disposition' => "attachment; filename=\"".$param->{upid}."\"", 'content-disposition' => "attachment; filename=\"".$download_name."\"",
}, },
}, },
} else { } else {