proxmox-mirrors/pve-manager
1
0
Fork 0
mirror of https://git.proxmox.com/git/pve-manager synced 2025-07-29 14:29:21 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

ui: lxc options: disable features edit as non-root when container is privileged

Browse Source 
The backend won't allow any edits in this case, so better just disable
the edit button altogether.

Co-developed-by: Fabian Grünbichler <f.gruenbichler@proxmox.com>
Signed-off-by: Fabian Ebner <f.ebner@proxmox.com>
This commit is contained in:
Fabian Ebner 2021-08-13 11:10:12 +02:00 committed by Thomas Lamprecht
parent 8c4ec1aef8
commit 2bc71fd9c3
1 changed files with 10 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

13
www/manager6/lxc/Options.js
View File

@ -136,8 +136,7 @@ Ext.define('PVE.lxc.Options', {
features: { features: {
header: gettext('Features'), header: gettext('Features'),
defaultValue: Proxmox.Utils.noneText, defaultValue: Proxmox.Utils.noneText,
editor: Proxmox.UserName === 'root@pam' || caps.vms['VM.Allocate'] editor: 'PVE.lxc.FeaturesEdit',
? 'PVE.lxc.FeaturesEdit' : undefined,
}, },
hookscript: { hookscript: {
header: gettext('Hookscript'), header: gettext('Hookscript'),
@ -174,7 +173,15 @@ Ext.define('PVE.lxc.Options', {
var pending = rec.data.delete || me.hasPendingChanges(key); var pending = rec.data.delete || me.hasPendingChanges(key);
var rowdef = rows[key]; var rowdef = rows[key];
edit_btn.setDisabled(!rowdef.editor); if (key === 'features') {
let unprivileged = me.getStore().getById('unprivileged').data.value;
let root = Proxmox.UserName === 'root@pam';
let vmalloc = caps.vms['VM.Allocate'];
edit_btn.setDisabled(!(root || (vmalloc && unprivileged)));
} else {
edit_btn.setDisabled(!rowdef.editor);
}
revert_btn.setDisabled(!pending); revert_btn.setDisabled(!pending);
}; };