From 2b4c02c00a0a9a33540d839b97ff1855fd8457b6 Mon Sep 17 00:00:00 2001 From: Aaron Lauterer Date: Mon, 2 Dec 2019 10:58:26 +0100 Subject: [PATCH] ui: mpedit: activate backup on MP creation This patch enables the backup checkbox by default for newly created LXC mount points. Hopefully this will help to avoid situations in the future where people realize too late that the mount point has not been backed up when they expected it to because they missed the checkbox. The reason why `view.isCreate` is not passed directly is because AFAIU the 'view.isCreate' can have one of three values: * null - editing an existing mount point * true - creating a new mp * array('unusedX') - adding an unused disk again Signed-off-by: Aaron Lauterer --- www/manager6/lxc/MPEdit.js | 10 ++++++++-- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/www/manager6/lxc/MPEdit.js b/www/manager6/lxc/MPEdit.js index 780bef0f..9f84bcc2 100644 --- a/www/manager6/lxc/MPEdit.js +++ b/www/manager6/lxc/MPEdit.js @@ -134,6 +134,11 @@ Ext.define('PVE.lxc.MountPointInputPanel', { vm.set('node', view.nodename); vm.set('unpriv', view.unprivileged); vm.set('hideStorSelector', view.unused || !view.isCreate); + + // can be array if created from unused disk + if (view.isCreate) { + vm.set('isIncludedInBackup', true); + } } }, @@ -240,10 +245,11 @@ Ext.define('PVE.lxc.MountPointInputPanel', { { xtype: 'proxmoxcheckbox', name: 'backup', - fieldLabel: gettext('Backup'), + fieldLabel: gettext('Include in backup'), bind: { hidden: '{isRoot}', - disabled: '{isBindOrRoot}' + disabled: '{isBindOrRoot}', + value: '{isIncludedInBackup}' } } ],