From 2a5fd75de53aa5d9c9e9df7aed87689a8e976467 Mon Sep 17 00:00:00 2001
From: Thomas Lamprecht <t.lamprecht@proxmox.com>
Date: Sat, 20 Apr 2024 17:27:44 +0200
Subject: [PATCH] ui: browser local settings: add new
 edit-notes-on-double-click option

The NotesView in the widget-toolkit learned to respect this opt-out
setting recently.

Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
---
 www/manager6/window/Settings.js | 17 +++++++++++++++--
 1 file changed, 15 insertions(+), 2 deletions(-)

diff --git a/www/manager6/window/Settings.js b/www/manager6/window/Settings.js
index 5cf7a70f..9af11850 100644
--- a/www/manager6/window/Settings.js
+++ b/www/manager6/window/Settings.js
@@ -41,6 +41,7 @@ Ext.define('PVE.window.Settings', {
 	    me.lookup('summarycolumns').setValue(summarycolumns);
 
 	    me.lookup('guestNotesCollapse').setValue(sp.get('guest-notes-collapse', 'never'));
+	    me.lookup('editNotesOnDoubleClick').setValue(sp.get('edit-notes-on-double-click', false));
 
 	    var settings = ['fontSize', 'fontFamily', 'letterSpacing', 'lineHeight'];
 	    settings.forEach(function(setting) {
@@ -146,6 +147,9 @@ Ext.define('PVE.window.Settings', {
 	    'field[reference=guestNotesCollapse]': {
 		change: (e, v) => Ext.state.Manager.getProvider().set('guest-notes-collapse', v),
 	    },
+	    'field[reference=editNotesOnDoubleClick]': {
+		change: (e, v) => Ext.state.Manager.getProvider().set('edit-notes-on-double-click', v),
+	    },
 	},
     },
 
@@ -250,7 +254,7 @@ Ext.define('PVE.window.Settings', {
 	    {
 		xtype: 'proxmoxKVComboBox',
 		fieldLabel: gettext('Summary columns') + ':',
-		labelWidth: 150,
+		labelWidth: 125,
 		stateId: 'summarycolumns',
 		reference: 'summarycolumns',
 		comboItems: [
@@ -263,7 +267,7 @@ Ext.define('PVE.window.Settings', {
 	    {
 		xtype: 'proxmoxKVComboBox',
 		fieldLabel: gettext('Guest Notes') + ':',
-		labelWidth: 150,
+		labelWidth: 125,
 		stateId: 'guest-notes-collapse',
 		reference: 'guestNotesCollapse',
 		comboItems: [
@@ -272,6 +276,15 @@ Ext.define('PVE.window.Settings', {
 		    ['auto', 'auto (Collapse if empty)'],
 		],
 	    },
+	    {
+		xtype: 'checkbox',
+		fieldLabel: gettext('Notes'),
+		labelWidth: 125,
+		boxLabel: gettext('Open editor on double-click'),
+		reference: 'editNotesOnDoubleClick',
+		inputValue: true,
+		uncheckedValue: false,
+	    },
 	],
     },
     {