From 27af8ed019c700c6869a8018a10b5367a2a8ec6a Mon Sep 17 00:00:00 2001 From: Thomas Lamprecht Date: Fri, 6 Mar 2020 20:17:34 +0100 Subject: [PATCH] ui dc/options: refactor render_bwlimits while this /could/ (not benched marked in any way) be slower it operates on so small data sets that this isn't worth it having double the code lines. A map + join is still quite readable and not yet "code golfy" Signed-off-by: Thomas Lamprecht --- www/manager6/dc/OptionView.js | 16 +++------------- 1 file changed, 3 insertions(+), 13 deletions(-) diff --git a/www/manager6/dc/OptionView.js b/www/manager6/dc/OptionView.js index 53a37184..6497648c 100644 --- a/www/manager6/dc/OptionView.js +++ b/www/manager6/dc/OptionView.js @@ -60,20 +60,10 @@ Ext.define('PVE.dc.OptionView', { return gettext("None"); } - let retval = ""; - let first = true; let parsed = PVE.Parser.parsePropertyString(value); - - Ext.Object.each(parsed, (k, v) => { - if (!first) { - retval += ", "; - } - // v is in KiB/s - retval += k + ": " + Proxmox.Utils.format_size(v * 1024) + "/s"; - first = false; - }); - - return retval; + return Object.entries(parsed) + .map(([k, v]) => k + ": " + Proxmox.Utils.format_size(v * 1024) + "/s") + .join(','); }, initComponent : function() {