proxmox-mirrors/pve-manager
1
0
Fork 0
mirror of https://git.proxmox.com/git/pve-manager synced 2025-07-27 03:55:33 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

api: replication: don't send mails about failed replication only once

Browse Source 
but rather multiple times becoming exponentially less frequent.

Suggested-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
Signed-off-by: Fabian Ebner <f.ebner@proxmox.com>
This commit is contained in:
Fabian Ebner 2022-04-22 14:15:48 +02:00 committed by Thomas Lamprecht
parent dcc7676af7
commit 237f00be03
1 changed files with 14 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

15
PVE/API2/Replication.pm
View File

@ -74,6 +74,19 @@ sub run_single_job {
sub run_jobs { sub run_jobs {
my ($now, $logfunc, $verbose, $mail) = @_; my ($now, $logfunc, $verbose, $mail) = @_;
my $mail_at_fail_count = sub {
my ($fail_count) = @_;
return 1 if $fail_count == 1;
# failing job is re-tried every half hour, try to send one mail after 1, 2, 4, 8, etc. days
my $i = 1;
while ($i * 48 < $fail_count) {
$i = $i * 2;
}
return $i * 48 == $fail_count;
};
my $iteration = $now // time(); my $iteration = $now // time();
my $code = sub { my $code = sub {
@ -93,7 +106,7 @@ sub run_jobs {
my $jobstate = PVE::ReplicationState::extract_job_state($state, $jobcfg); my $jobstate = PVE::ReplicationState::extract_job_state($state, $jobcfg);
eval { eval {
PVE::Tools::sendmail('root', "Replication Job: $jobcfg->{id} failed", $err) PVE::Tools::sendmail('root', "Replication Job: $jobcfg->{id} failed", $err)
if $jobstate->{fail_count} == 1 && $mail; if $mail && $mail_at_fail_count->($jobstate->{fail_count});
}; };
warn ": $@" if $@; warn ": $@" if $@;
} }