proxmox-mirrors/pve-manager
1
0
Fork 0
mirror of https://git.proxmox.com/git/pve-manager synced 2025-08-04 23:24:48 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

ui: user view: fix calling order of gettext

Browse Source 
One must not call gettext on the already formatted string, as we
cannot translate it for any possible value, rather the format string
it self needs to be gettext'd, then the translator can position the
variable template placeholders however it's correct for their
language without having to care about any value this could be called
with.

Fixes: d057929f ("ui: user view: fix calling order of gettext")
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
This commit is contained in:
Thomas Lamprecht 2023-06-09 09:52:42 +02:00
parent 2ef204f91b
commit 22fcd0069a
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
www/manager6/dc/UserView.js
View File

@ -101,7 +101,7 @@ Ext.define('PVE.dc.UserView', {
(rec.data['totp-locked'] || rec.data['tfa-locked-until'])),
handler: function(btn, event, rec) {
Ext.Msg.confirm(
gettext(Ext.String.format('Unlock TFA authentication for {0}', rec.data.userid)),
Ext.String.format(gettext('Unlock TFA authentication for {0}'), rec.data.userid)),
gettext("Locked 2nd factors can happen if the user's password was leaked. Are you sure you want to unlock the user?"),
function(btn_response) {
if (btn_response === 'yes') {