From 18af64dc99b3619bd4dba0c29ca1bc33faaeba3a Mon Sep 17 00:00:00 2001 From: Thomas Lamprecht Date: Wed, 8 Sep 2021 16:09:40 +0200 Subject: [PATCH] ui: backup job detail view: merge mail notification when/to fields While it surely is nice to follow the layout of the job creation/edit panel for sharing familiarity, it does not means that we need to show the data 1:1, we can profit from the read-only fact and merge stuff a bit, like the mail to/when field. Signed-off-by: Thomas Lamprecht --- www/manager6/dc/Backup.js | 19 +++++-------------- 1 file changed, 5 insertions(+), 14 deletions(-) diff --git a/www/manager6/dc/Backup.js b/www/manager6/dc/Backup.js index 9c903e6d..74f896c4 100644 --- a/www/manager6/dc/Backup.js +++ b/www/manager6/dc/Backup.js @@ -636,26 +636,17 @@ Ext.define('PVE.dc.BackupInfo', { }, ], column2: [ - { - xtype: 'displayfield', - name: 'mailto', - fieldLabel: gettext('Send email to'), - }, { xtype: 'displayfield', name: 'mailnotification', fieldLabel: gettext('Email notification'), renderer: function(value) { - let msg; - switch (value) { - case 'always': - msg = gettext('Always'); - break; - case 'failure': - msg = gettext('On failure only'); - break; + let mailto = this.up('pveBackupInfo')?.record?.mailto || 'root@localhost'; + let when = gettext('Always'); + if (value === 'failure') { + when = gettext('On failure only'); } - return msg; + return `${when} (${mailto})`; }, }, {