ui: dc: log, options, support: eslint fixes and code cleanup/refactoring

Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
This commit is contained in:
Thomas Lamprecht 2021-05-18 14:45:55 +02:00
parent 9f84f443aa
commit 03153d556b
3 changed files with 11 additions and 17 deletions

View File

@ -8,9 +8,9 @@ Ext.define('PVE.dc.Log', {
alias: ['widget.pveClusterLog'], alias: ['widget.pveClusterLog'],
initComponent: function() { initComponent: function() {
var me = this; let me = this;
var logstore = Ext.create('Proxmox.data.UpdateStore', { let logstore = Ext.create('Proxmox.data.UpdateStore', {
storeid: 'pve-cluster-log', storeid: 'pve-cluster-log',
model: 'proxmox-cluster-log', model: 'proxmox-cluster-log',
proxy: { proxy: {
@ -18,8 +18,7 @@ Ext.define('PVE.dc.Log', {
url: '/api2/json/cluster/log', url: '/api2/json/cluster/log',
}, },
}); });
let store = Ext.create('Proxmox.data.DiffStore', {
var store = Ext.create('Proxmox.data.DiffStore', {
rstore: logstore, rstore: logstore,
appendAtStart: true, appendAtStart: true,
}); });
@ -31,13 +30,12 @@ Ext.define('PVE.dc.Log', {
viewConfig: { viewConfig: {
trackOver: false, trackOver: false,
stripeRows: true, stripeRows: true,
getRowClass: function(record, index) { getRowClass: function(record, index) {
var pri = record.get('pri'); let pri = record.get('pri');
if (pri && pri <= 3) { if (pri && pri <= 3) {
return "proxmox-invalid-row"; return "proxmox-invalid-row";
} }
return undefined;
}, },
}, },
sortableColumns: false, sortableColumns: false,

View File

@ -12,7 +12,7 @@ Ext.define('PVE.dc.OptionView', {
opts = opts || {}; opts = opts || {};
me.rows = me.rows || {}; me.rows = me.rows || {};
let canEdit = !opts.hasOwnProperty('caps') || opts.caps; let canEdit = !Object.prototype.hasOwnProperty.call(opts, 'caps') || opts.caps;
me.rows[name] = { me.rows[name] = {
required: true, required: true,
defaultValue: opts.defaultValue, defaultValue: opts.defaultValue,
@ -68,8 +68,6 @@ Ext.define('PVE.dc.OptionView', {
initComponent: function() { initComponent: function() {
var me = this; var me = this;
var caps = Ext.state.Manager.get('GuiCap');
me.add_combobox_row('keyboard', gettext('Keyboard Layout'), { me.add_combobox_row('keyboard', gettext('Keyboard Layout'), {
renderer: PVE.Utils.render_kvm_language, renderer: PVE.Utils.render_kvm_language,
comboItems: PVE.Utils.kvm_keymap_array(), comboItems: PVE.Utils.kvm_keymap_array(),
@ -150,10 +148,9 @@ Ext.define('PVE.dc.OptionView', {
fieldLabel: gettext('U2F AppID URL'), fieldLabel: gettext('U2F AppID URL'),
emptyText: gettext('Defaults to origin'), emptyText: gettext('Defaults to origin'),
value: '', value: '',
skipEmptyText: true,
deleteEmpty: true, deleteEmpty: true,
submitEmptyText: false,
skipEmptyText: true, skipEmptyText: true,
submitEmptyText: false,
}, { }, {
xtype: 'textfield', xtype: 'textfield',
name: 'origin', name: 'origin',

View File

@ -48,20 +48,19 @@ Ext.define('PVE.dc.Support', {
}, },
initComponent: function() { initComponent: function() {
var me = this; let me = this;
var reload = function() { let reload = function() {
Proxmox.Utils.API2Request({ Proxmox.Utils.API2Request({
url: '/nodes/localhost/subscription', url: '/nodes/localhost/subscription',
method: 'GET', method: 'GET',
waitMsgTarget: me, waitMsgTarget: me,
failure: function(response, opts) { failure: function(response, opts) {
Ext.Msg.alert(gettext('Error'), response.htmlStatus); Ext.Msg.alert(gettext('Error'), response.htmlStatus);
me.update('Unable to load subscription status' + ": " + response.htmlStatus); me.update(`${gettext('Unable to load subscription status')}: ${response.htmlStatus}`);
}, },
success: function(response, opts) { success: function(response, opts) {
var data = response.result.data; let data = response.result.data;
if (data.status === 'Active') { if (data.status === 'Active') {
if (data.level === 'c') { if (data.level === 'c') {
me.updateCommunity(data); me.updateCommunity(data);