From 00e4bd2e10ae54a92c7e52c7590c20d0828decf0 Mon Sep 17 00:00:00 2001 From: Dominik Csapak Date: Mon, 21 Nov 2022 15:39:06 +0100 Subject: [PATCH] ui: qemu disk: honor iothread setting from config To have a IOThread on by default in the wizard and on disk add, we added a 'bind' for the value here. This also changes the value for existing VM disks, and if one does not notice, modifies it away again (since we don't have the controller here and isSCSISingle is false) Simply don't bind value when we edit a VM disk from config Note that this is only an issue in Chromium based browsers. Signed-off-by: Dominik Csapak --- www/manager6/qemu/HDEdit.js | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/www/manager6/qemu/HDEdit.js b/www/manager6/qemu/HDEdit.js index 921bfe72..b78647ec 100644 --- a/www/manager6/qemu/HDEdit.js +++ b/www/manager6/qemu/HDEdit.js @@ -255,10 +255,12 @@ Ext.define('PVE.qemu.HDInputPanel', { name: 'iothread', fieldLabel: 'IO thread', clearOnDisable: true, - bind: { + bind: me.insideWizard || me.isCreate ? { disabled: '{!isVirtIO && !isSCSI}', // Checkbox.setValue handles Arrays in a different way, therefore cast to bool value: '{!!isVirtIO || (isSCSI && isSCSISingle)}', + } : { + disabled: '{!isVirtIO && !isSCSI}', }, }, );