From c473995e653b50b695cea6bb0921a78bcd0c5356 Mon Sep 17 00:00:00 2001 From: Oguz Bektas Date: Wed, 10 Nov 2021 14:07:46 +0100 Subject: [PATCH] proxmox-boot: esp config: avoid leading whitespace in initrd/linux options Not an actual issue, the systemd parser just skips those whitespaces[0], but it may confuse people and lead to false-positive conclusions about a culprit for loader issues, so fix that up. [0]: https://github.com/systemd/systemd/blob/main/src/boot/efi/boot.c#L1064 diff before -> after: version 5.11.22-7-pve options root=ZFS=rpool/ROOT/pve-1 boot=zfs iommu=pt - linux /EFI/proxmox/5.11.22-7-pve/vmlinuz-5.11.22-7-pve - initrd /EFI/proxmox/5.11.22-7-pve/initrd.img-5.11.22-7-pve +linux /EFI/proxmox/5.11.22-7-pve/vmlinuz-5.11.22-7-pve +initrd /EFI/proxmox/5.11.22-7-pve/initrd.img-5.11.22-7-pve Fixes: 2a8a4b5 ("proxmox-boot: fix #3632 copy kernel+initrd unconditionally") Signed-off-by: Oguz Bektas [ Thomas: Clarify that the commit does not fix anything but is still good to have ] Signed-off-by: Thomas Lamprecht --- proxmox-boot/zz-proxmox-boot | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/proxmox-boot/zz-proxmox-boot b/proxmox-boot/zz-proxmox-boot index 4bd63a6..52171b2 100755 --- a/proxmox-boot/zz-proxmox-boot +++ b/proxmox-boot/zz-proxmox-boot @@ -140,8 +140,8 @@ copy_and_config_kernels() { title ${LOADER_TITLE} version ${kver} options ${CMDLINE} - linux /${KERNEL_ESP_DIR}/vmlinuz-${kver} - initrd /${KERNEL_ESP_DIR}/initrd.img-${kver} + linux /${KERNEL_ESP_DIR}/vmlinuz-${kver} + initrd /${KERNEL_ESP_DIR}/initrd.img-${kver} EOF else warn " Copying kernel ${kver}"