From bf10a73e5a1f8b684062fbe5b9b64fcdea8cc4b6 Mon Sep 17 00:00:00 2001
From: Thomas Lamprecht <t.lamprecht@proxmox.com>
Date: Tue, 22 Feb 2022 17:28:34 +0100
Subject: [PATCH] boot-tool: shellcheck lint fixes

Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
---
 bin/proxmox-boot-tool | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/bin/proxmox-boot-tool b/bin/proxmox-boot-tool
index 178b6fb..766eaad 100755
--- a/bin/proxmox-boot-tool
+++ b/bin/proxmox-boot-tool
@@ -98,7 +98,7 @@ format() {
 
 	part_basename=$(basename "$bdev")
 	if [ -z "$part_basename" ]; then
-		if [ $part != $bdev ]; then
+		if [ "$part" != "$bdev" ]; then
 		    symlinkmsg=" -> '$bdev'"
 		fi
 		warn "E: unable to determine basename of '$part'$symlinkmsg"
@@ -162,7 +162,7 @@ init() {
 	else
 		echo "Installing grub i386-pc target.."
 		grub-install.real \
-			--boot-directory $esp_mp \
+			--boot-directory "$esp_mp" \
 			--target i386-pc \
 			--no-floppy \
 			--bootloader-id='proxmox' \
@@ -183,7 +183,7 @@ _clean_impl() {
 		warn 'E: /dev/disk/by-uuid does not exist, aborting!'
 		exit 1
 	fi
-	echo -n "Checking whether ESP '$curr_uuid' exists.. "
+	printf "Checking whether ESP '%s' exists.. " "$curr_uuid" # avoid newline
 	if [ -e "/dev/disk/by-uuid/$curr_uuid" ]; then
 		echo "Found!"
 	else