While we still rely on the global $env, that is more contained and
capsuled, and with moving over to that a further split, or move to a
singleton, is easier in the future.
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
in preparation of moving more installer environment info in there.
Move also the (currently unused) CD info in there
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
When using the module -init switch, the init method was called in
module import method, which means every time this was loaded, even if
just for a quick syntax+ check using `perl -I. -wc`, failing then if
no X11 connection was available.
Calling this manually after module load finished should have no
consequences, and if, that should be fixed there, without going back
to doing GUI init in module load/import steps - that's just ugly.
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
.. and introduce some helpers to finding/getting cached disks.
The hd_list method, which scans for physical disks, can be made
private with this change.
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
The assignment to () is confusing, as that's effectively identical
with not assigning it at all and later auto-vivify it to an array
ref, make that more explicit instead.
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
we need to access the test images from other locations than
proxinstall, so make that state accessible.
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
basically only used for change-tracking on what targets to rebuild,
so avoid the need to have the list here duplicated, most files known
to git are installer files
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
Make it clearer that we actually pass one, or a list of, test-images
as CLI option and move the is-test-mode state into the setup module
(not enough code/reason to make a separate "env" or so module) in
preparation of further splitting out code into separate modules where
we then need to have the info about test-mode state available there
too.
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
this is a detail of the tz zoneinfo data/format, avoid to do the
replacement dance too.
IMO most users would be even rather confused by the Etc/ prefix.
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
Adds 'Etc/UTC' as option to the timezone selection, regardless of what
country is selected.
The 'Etc/' prefix needs to be stripped for the installation, as this
value is written to /etc/timezone. PVE/PMG/PBS already use 'UTC' without
the prefix, so avoid regressing them.
Signed-off-by: Christoph Heiss <c.heiss@proxmox.com>
to ensure we have enough space for more kernels and possible unified
kernel images (UKI) in the future.
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
