just some nitpicky changes.
v2:
- remove tag files
@Thomas: Like you thought, they are autogenerated by some vim plugin.
They usually sit quitely in the untracked files, but this time, I guess
I somehow I managed to add them in without noticing.. Apologies!
Signed-off-by: Dylan Whyte <d.whyte@proxmox.com>
this patch partially reverts 8bc528041b
by writing /etc/default/keyboard and running `setupcon` in the background
the delay should not harm the UX in the installer
Signed-off-by: Stoiko Ivanov <s.ivanov@proxmox.com>
certain tasks done during the installer need not block the GUI (e.g. setting
the keymap of the console, to have the correct one set in the shell on vt3)
and take a longer time.
This patch adds a simple run_in_background method, which forks and runs the
provided code in the child. Before exiting the children get reaped.
Signed-off-by: Stoiko Ivanov <s.ivanov@proxmox.com>
currently when using the previous/next buttons the keyboard layout gets
defined based on the detected/selected country, even if it was set to a
different value explicitly.
This patch changes the behaviour to only update the layout and set it in
the installer if it got actively changed, or if a different country was
selected
Signed-off-by: Stoiko Ivanov <s.ivanov@proxmox.com>
add more inner margin for scroll bar and reduce outer margins to
avoid to much empty border space.
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
in create_country_view() when setting the keyboard config
setupcon is too slow, causing installer to hang for some
seconds when switching to/from country view.
setxkbmap is enough during the installation (next step
password & email works fine with different keymaps), vt
is largely unused during it anyway.
Signed-off-by: Oguz Bektas <o.bektas@proxmox.com>
Only auto reboot if no error happened.
default to on, as this is normally wanted behavior - the success
screem does not allow to do anything else anyway, and the IP address
gets then also showed as issue banner after that reboot.
show some countdown (it's set to 5 seconds, but due some internal
delay it more like 3s)
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
Use two fields it a single row: [ <address> ] / [ <mask> ]
Make the others also a bit bigger for symmetry.
Adapt html templates respectively.
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
This is an enhancement for #2804
Having a shell waiting on vt3, it improves user experience if it has the
same keyboard map as the X11 installer.
This is accomplished by setting the contents of '/etc/default/keyboard' and
then running `setupcon`. Simply calling `loadkeys` would not work, since the
keymaps in debian are generated from the x11 definitions by ckbcomp and then
saved in '/etc/console-setup/'.
Signed-off-by: Stoiko Ivanov <s.ivanov@proxmox.com>
currently the installer prepares the ESP disks for ZFS, irrespective of the
boot-mode (EFI, legacy) - in order to enable users to change the boot-mode
in the BIOS and keep the system bootable.
This patch updates /etc/kernel/cmdline in both boot-modes, which is necessary
to make the system actually bootable (else the systemd-boot config uses
the cmdline from the installer).
Signed-off-by: Stoiko Ivanov <s.ivanov@proxmox.com>
we now can create a datastore on new disk(s) over api/ui so a
default datastore on the root mountpoint makes no sense anymore.
partially reverts commit ca74501dce
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
Tested locally in a VM:
The setsid was necessary to give the bash job-control (otherwise Ctrl+C would
simply kill the shell).
Signed-off-by: Stoiko Ivanov <s.ivanov@proxmox.com>
it's a bit brittle and login is weird (enter root user twice, pw
doesn't matters) and once exited it's gone, but it's just for
"emergency debugging" anyway
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
in some situations it is possible, that a disk does not have a
/dev/disk/by-id path. Reported cases are KVM with virtio-blk [0] and
with VMware player / workstation when using the paravirtual SCSI disk
types [1]. It can be reproduced in Proxmox VE by using virtio-blk disks
for the VM.
> The issue at hand happens because udev does not create the
> /dev/disk/by-id symlink in
> '/lib/udev/rules.d/60-persistent-storage.rules', since it does
> not have a serial-number for the device (which in the virtio-blk case
> is in turn maybe caused by qemu-server not adding one to the
> commandline).
Quoted from [2]
This regression was introduced with commit
e1b490865f which always replaced the disks
in the $vdev variable even if the result of the by-id lookup was
`undef`. Thus the paths did not point to any valid disk and the zpool
creation failed.
This patch replaces the disk paths with by-id paths only if they are
present.
[0] https://forum.proxmox.com/threads/installation-on-raidz-1-fails.65603/
[1] https://forum.proxmox.com/threads/not-install-promox-6-1-zfs-0-04-disk-vmware-15-pro.65269/
[2] https://pve.proxmox.com/pipermail/pve-devel/2020-February/041841.html
Signed-off-by: Aaron Lauterer <a.lauterer@proxmox.com>
This reverts commit 8ee12a1c34.
`policy-rc.d` invocation is still used by deb-systemd-invoke (1p), despite
it's by now unfitting name.
The policy-rc.d script the installer placed into the chroot prevents the
starting of services by (debianized) maintainer-scripts [0].
This should reduce installation time on one hand, and on the other hand does
mask errors in maintainer-scripts, which error out if no systemd is running
(e.g. inside the chroot)
Noticed the problem, when testing an unrelated patch and running into
an aborted installtion, due to a, already fixed, glitch (missing '||true')
in pve-lxc's postinst script.
[0] https://people.debian.org/~hmh/invokerc.d-policyrc.d-specification.txt
(did not find anything more current, contradicting the information there)
Signed-off-by: Stoiko Ivanov <s.ivanov@proxmox.com>
Packages which we have under control have to ensure themself that the
correct permissions are set, else the "install on top of Debian" also
fails. It just crowd proxinstall unecessarily, so avoid to add new
ones if possible. This specific one is handled in the respective
package since quite a bit.
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
