proxmox-mirrors/pve-http-server
1
0
Fork 0
mirror of https://git.proxmox.com/git/pve-http-server synced 2025-05-28 14:39:14 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

response: avoid linefeeds in response status

Browse Source 
basically only possible to trigger with chromium based browsers
(chrome, edge, opera) but besides those having the biggest usage
currently its not that nice in any way.

Users could inject headers in their response, which isn't really that
bad itself, as they won't really do anything at least for sane
browsers that don't allow setting third party cookies by default
(unlike again, chrome), in which case one can create huge cookies
that then trigger the max header size check on requests, DOS'ing an
user's access to a PVE interface if they can get them to visit a
malicious site (a clear cooki actione would allow visiting it again)

Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
Reported-by: STAR Labs <info@starlabs.sg>
This commit is contained in:
Thomas Lamprecht 2022-07-01 11:32:54 +02:00
parent be2215c4c2
commit f325788131
1 changed files with 8 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
src/PVE/APIServer/AnyEvent.pm
View File

@ -288,9 +288,16 @@ sub response {
my $code = $resp->code;
my $msg = $resp->message || HTTP::Status::status_message($code);
($msg) = $msg =~m/^(.*)$/m;
my $content = $resp->content;
# multiline mode only checks \n for $, so explicitly check for any \n or \r afterwards
($msg) = $msg =~ m/^(.*)$/m;
if ($msg =~ /[\r\n]/) {
$code = 400; # bad request from user
$msg = HTTP::Status::status_message($code);
$content = '';
}
if ($code =~ /^(1\d\d|[23]04)$/) {
# make sure informational, no content and not modified response send no content
$content = "";