proxmox-mirrors/pve-http-server
1
0
Fork 0
mirror of https://git.proxmox.com/git/pve-http-server synced 2025-07-03 21:18:06 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

fix regression in api/html (bootstrap) viewer

Browse Source 
Since v5.13, URI::Escape handles the 'unsafe characters' parameter
differently than before, i.e., enforcing what is documented [0]:

 The set is specified as a string that can be used in a regular
 expression character class (between [ ]).

So, the leading/trailing [] were never supposed to be there.

Note that since v5.15 we could also pass a qr// regex object.

[0]: 1a4ed66802

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
 [ T: Add details and mention regex objects ]
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
This commit is contained in:
Dominik Csapak 2023-05-30 13:56:25 +02:00 committed by Thomas Lamprecht
parent 1a555dd93c
commit d0f4b94507
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/PVE/APIServer/Formatter/Bootstrap.pm
View File

@ -167,7 +167,7 @@ sub el {
foreach my $attr (keys %param) { foreach my $attr (keys %param) {
next if $skip->{$attr}; next if $skip->{$attr};
my $v = $noescape->{$attr} ? $param{$attr} : uri_escape_utf8($param{$attr},"[^\/\ A-Za-z0-9\-\._~]"); my $v = $noescape->{$attr} ? $param{$attr} : uri_escape_utf8($param{$attr}, "^\/\ A-Za-z0-9\-\._~");
next if !defined($v); next if !defined($v);
if ($boolattr->{$attr}) { if ($boolattr->{$attr}) {
$html .= " $attr" if $v; $html .= " $attr" if $v;