proxmox-mirrors/pve-http-server
1
0
Fork 0
mirror of https://git.proxmox.com/git/pve-http-server synced 2025-05-29 21:01:06 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

access control: avoid "uninitialized value" warning if using IP ranges

Browse Source 
ALLOW_FROM/DENY_FROM accept any syntax understood by Net::IP. However,
if an IP range like "10.1.1.1-10.1.1.3" is configured, a confusing
Perl warning is printed to the syslog on a match:

  Use of uninitialized value in concatenation (.) or string at [...]

The reason is that we use Net::IP::prefix to prepare a debug message,
but this returns undef if a range was specified. To avoid the warning,
use Net::IP::print to obtain a string representation instead.

Signed-off-by: Friedrich Weber <f.weber@proxmox.com>
This commit is contained in:
Friedrich Weber 2024-01-24 12:38:56 +01:00 committed by Fabian Grünbichler
parent 38535a67df
commit a8dd7b668e
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
src/PVE/APIServer/AnyEvent.pm
View File

@ -1761,7 +1761,7 @@ sub check_host_access {
foreach my $t (@{$self->{allow_from}}) { foreach my $t (@{$self->{allow_from}}) {
if ($t->overlaps($cip)) { if ($t->overlaps($cip)) {
$match_allow = 1; $match_allow = 1;
$self->dprint("client IP allowed: ". $t->prefix()); $self->dprint("client IP allowed: ". $t->print());
last; last;
} }
} }
@ -1770,7 +1770,7 @@ sub check_host_access {
if ($self->{deny_from}) { if ($self->{deny_from}) {
foreach my $t (@{$self->{deny_from}}) { foreach my $t (@{$self->{deny_from}}) {
if ($t->overlaps($cip)) { if ($t->overlaps($cip)) {
$self->dprint("client IP denied: ". $t->prefix()); $self->dprint("client IP denied: ". $t->print());
$match_deny = 1; $match_deny = 1;
last; last;
} }