proxmox-mirrors/pve-http-server
1
0
Fork 0
mirror of https://git.proxmox.com/git/pve-http-server synced 2025-08-05 04:30:29 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

acknowledge content-disposition header

Browse Source 
Acknowledging the Content-Disposition header makes it possible for the
backend to tell the browser whether a file should be downloaded,
rather than displayed inline, and what it's default name should be.

Signed-off-by: Daniel Tschlatscher <d.tschlatscher@proxmox.com>
This commit is contained in:
Daniel Tschlatscher 2022-09-07 10:56:28 +02:00 committed by Thomas Lamprecht
parent 4099febef5
commit 9c1388daf1
1 changed files with 3 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
src/PVE/APIServer/AnyEvent.pm
View File

@ -426,6 +426,7 @@ sub send_file_start {
if (ref($download) eq 'HASH') { if (ref($download) eq 'HASH') {
$mime = $download->{'content-type'}; $mime = $download->{'content-type'};
my $encoding = $download->{'content-encoding'}; my $encoding = $download->{'content-encoding'};
my $disposition = $download->{'content-disposition'};
if ($download->{path} && $download->{stream} && if ($download->{path} && $download->{stream} &&
$reqstate->{request}->header('PVEDisableProxy')) $reqstate->{request}->header('PVEDisableProxy'))
@ -438,6 +439,7 @@ sub send_file_start {
Content_Type => $mime, Content_Type => $mime,
); );
$header->header('Content-Encoding' => $encoding) if defined($encoding); $header->header('Content-Encoding' => $encoding) if defined($encoding);
$header->header('Content-Disposition' => $disposition) if defined($disposition);
# we need some data so Content-Length gets set correctly and # we need some data so Content-Length gets set correctly and
# the proxy doesn't wait for more data - place a canary # the proxy doesn't wait for more data - place a canary
my $resp = HTTP::Response->new(200, "OK", $header, "error canary"); my $resp = HTTP::Response->new(200, "OK", $header, "error canary");
@ -456,6 +458,7 @@ sub send_file_start {
if ($download->{stream}) { if ($download->{stream}) {
my $header = HTTP::Headers->new(Content_Type => $mime); my $header = HTTP::Headers->new(Content_Type => $mime);
$header->header('Content-Encoding' => $encoding) if defined($encoding); $header->header('Content-Encoding' => $encoding) if defined($encoding);
$header->header('Content-Disposition' => $disposition) if defined($disposition);
my $resp = HTTP::Response->new(200, "OK", $header); my $resp = HTTP::Response->new(200, "OK", $header);
$self->response($reqstate, $resp, undef, 1, 0, $fh); $self->response($reqstate, $resp, undef, 1, 0, $fh);
return; return;